- Issue created by @VadmanBat
- Assigned to Tanushree Gupta
- Merge request !20Issue 3445521: Styled the main-menu in mobile and tabs view. → (Open) created by Tanushree Gupta
- Issue was unassigned.
- Status changed to Needs review
6 months ago 7:47am 17 July 2024 Design the navigation bar of of mobile and tabs.
Here is the MR: https://git.drupalcode.org/project/creative_innovative/-/merge_requests/20
Here is the screenshot attached for reference.- Status changed to Needs work
5 months ago 8:02am 20 August 2024 - 🇮🇳India Kanchan Bhogade
Hi
I have tested "Expanded Menus" on Drupal 10.3.1 with the Theme version 9.1.0For the Desktop, The hover effect works as expected without the MR.
MR !20 applied cleanly and checked Menus for mobile and Tab
Test Result:
The Navigation menus are styled for Mobile and Tab but the Expanded Menu "arrow" does not change as expected and the "arrow" does not have the right side spacing.Attaching Screenshot for reference
- Status changed to Needs review
5 months ago 11:22am 21 August 2024 The code has been updated according to the comments. Now the arrow direction changes when opening and closing the submenu on all screen sizes (desktop, tablets, and mobile). Additionally, the arrow position has been corrected for mobile and tablet screen sizes.
Here is the screenshot attached for reference.- 🇮🇳India Kanchan Bhogade
Tested updated MR 20 on Drupal 10.3
Test Result:
The arrow direction works as expected on all screen sizes. The arrow position has been corrected for mobile and tablet screen sizes.RTBC+1
Attaching Screenshot Hello @tanushree gupta,
The menu arrow, position and design in mobile devices looks good to me after applying the MR!20 and it applies cleanly, however the MR contains css file changes and is missing the scss file changes. Since the theme is using scss, we need to convert the css changes into scss. Therefore, moving to NW.
Thanks- 🇮🇳India sagarmohite0031
Hello, Getting error while applying MR.
attaching screenshots- - 🇮🇳India Kanchan Bhogade
Hi
Trying to apply MR20 but Patch is throwing an errormoving to "Need Work"
Screenshot for reference - Merge request !25Issue 3445521: Added styling for mobile navigation. → (Open) created by Tanushree Gupta
tanushree gupta → changed the visibility of the branch Update-Navbar to hidden.
tanushree gupta → changed the visibility of the branch Update-Navbar to hidden.
There were several issues with that MR, but they have now been resolved. Please check.
MR: https://git.drupalcode.org/project/creative_innovative/-/merge_requests/25Hello @tanushree gupta,
I reviewed the MR!25 and found that you've included the scss as I had mentioned earlier in the comment. However, you seemed to have removed a small snippet which has already been merged to resolve this 3391594 🐛 In Footer section need to align Footer title with footer Menu. Fixed issue. Additionally, the MR!25 is throwing error on applying the patch on current version 9.1.0.error: patch failed: lib/style.css:683 error: lib/style.css: patch does not apply error: patch failed: scss/style.scss:8 error: scss/style.scss: patch does not apply error: patch failed: templates/layout/page.html.twig:96 error: templates/layout/page.html.twig: patch does not apply
Although the patch applies cleanly when the theme is cloned and applied on the 1.0.x branch. The menu arrow, position and design in mobile devices looks good to me. Moving to NW to resolve the removed snippet. Attaching ss of after patch.
I would suggest to create a MR keeping the target branch as 9.1.x, as the current version 9.1.0 also contains the menu design break in mobile devices.
ThanksI mistakenly removed certain lines of code, but I have now corrected this error. I have tested the MR patch in both 1.0.x and 9.1.0 versions, and it is working perfectly in both cases. Regarding the previous screenshot you shared, the hamburger menu is not in the correct position because the cache was not cleared after applying the patch. Please clear the cache after applying the patch.
I am attaching a screenshot for the reference.Hello @tanushree gupta,
I've reviewed your new changes, the previously mentioned issues regarding the removal of snippet has been resolved. Thanks for pointing out the hamburger menu position, I cleared the cache after applying the patch and it was rectified. The patch applied cleanly in 1.0.x and 9.1.0 versions of the theme. The mentioned issue is resolved hence moving to RTBC.
Thanks