Search icon is overlapping with the search text.

Created on 8 August 2023, 11 months ago
Updated 18 April 2024, 2 months ago

Problem/Motivation

Search icon and text overlapping issue.

Steps to reproduce

  1. Install gin theme
  2. Install Admin tool bar module
  3. Go to the theme settings and in Navigation (Drupal Toolbar) choose Legacy, Classic Drupal Toolbar
  4. Go to admin/config/user-interface/admin-toolbar-search-settings
  5. Activated Display the search input as a menu item.
  6. Click on search bar

you will find this issue.

Proposed resolution

Hide the search text and search go to the search input.

๐Ÿ› Bug report
Status

Needs review

Component

Code

Created by

๐Ÿ‡ฎ๐Ÿ‡ณIndia djsagar

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @djsagar
  • Status changed to Needs review 11 months ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia djsagar

    I created patch for above issue, please review and share your feedback.

    Thanks!

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia mayursolaskar

    I followed the steps provided by @djsagar and was able to reproduce the issue. After that, I applied patch #2, which resolved the problem. However, on mobile and iPad screens, I noticed that the search icon is slightly elevated and not centred properly. To address this, Iโ€™ve created a patch that resolves this specific issue.
    Thank You

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Jay Jangid

    I have encountered this problem while testing in Drupal 9.5.x.
    Unfortunately, the patch did not apply successfully in my case.
    Resulting in the following errors:

    error: patch failed: dist/css/components/toolbar.css:784
    error: dist/css/components/toolbar.css: patch does not apply
    error: patch failed: styles/components/toolbar.scss:628
    error: styles/components/toolbar.scss: patch does not apply

    Thank you.

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia swatidhurandhar

    Hello,
    I also tried to apply patch from #3 in Drupal10.1 but it had some error. So I created a new patch for icon overlapping issue in all the devices and changed the color of search icon in admin toolbar as well. Please review.
    Thanks

  • Applied #3 patch and it is cleanly applied and resolved the issue as well on both the screens (Desktop and mobile) but on the mobile screen there is a minor icon alignment issue still exists.

    Minor Alignment issue on mobile

    Desktop screen after patch

    Mobile screen after patch

  • To fix the alignment issue update this CSS -

    @media (max-width: 60.99em)
    #toolbar-item-administration-search-tray nav .js-form-type-search::before {
        top: 18px;
    }
  • Status changed to Needs work 5 months ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia djsagar

    updating tag so moving NW.

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia divya.sejekan

    Tested with the patch - 3379974-3.patch . The issue is resolved in desktop , But bit misaligned in mobile and tablet . Same as raised by @ShwetaSharma. So moving it to Need Work.

    Testing steps :

    • Install gin theme
    • Install Admin tool bar module
    • Go to the theme settings and in Navigation (Drupal Toolbar) choose Legacy, Classic Drupal Toolbar
    • Go to admin/config/user-interface/admin-toolbar-search-settings
    • Activated Display the search input as a menu item.
    • Click on search bar
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia djsagar

    Hi @divya.sejekan please share before and after screen shorts for reference if you tested this issue.

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia djsagar
  • Status changed to Needs review 5 months ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia djsagar

    Let's wait for the maintainer review so moving NR.

  • Removing tag as screenshots are added now in #13

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia nilesh.k

    Tested with the patch - 3379974-5patch. The issue is resolved on desktop and mobile. This is good to go. Please check the screenshots.

    Testing steps:

    1. Install the Gin theme.
    2. Install the Admin Toolbar module.
    3. Go to the theme settings and navigate to Navigation (Drupal Toolbar), then choose Legacy or Classic Drupal Toolbar.
    4. Proceed to admin/config/user-interface/admin-toolbar-search-settings.
    5. Activate "Display the search input as a menu item."
    6. Click on the search bar.




  • Status changed to RTBC 4 months ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia djsagar

    Removing tag as tested and added screenshots in #16. moving to RTBC.

  • Status changed to Needs work 3 months ago
  • ๐Ÿ‡จ๐Ÿ‡ญSwitzerland saschaeggi Zurich

    Can we get a working MR here? TY in advance

  • Merge request !400Update 2 files โ†’ (Open) created by djsagar
  • Status changed to Needs review 3 months ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia djsagar

    @saschaeggi Kindly review.

  • Pipeline finished with Failed
    3 months ago
    Total: 246s
    #136605
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia ehsann_95

    ahsannazir โ†’ made their first commit to this issueโ€™s fork.

  • Pipeline finished with Success
    3 months ago
    Total: 221s
    #137176
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Kanchan Bhogade

    Hi
    I've tested MR !400 on Drupal version 10.0.1
    MR applied Successfully.....

    The Search icon and text not overlapping.

    Adding screenshots for reference

    Keeping in "needs review" for code verification

Production build 0.69.0 2024