๐Ÿ‡ฎ๐Ÿ‡ณIndia @mayursolaskar

Account created on 24 January 2022, almost 3 years ago
#

Merge Requests

Recent comments

๐Ÿ‡ฎ๐Ÿ‡ณIndia mayursolaskar

Thank you, @tguerineau. I have applied the MR !31, and the changes are working as expected. The comment is now visible to users and the comment box is also in dark mode. I have attached a screenshot for your reference.RTBC+
Thank You.

๐Ÿ‡ฎ๐Ÿ‡ณIndia mayursolaskar

I have applied Patch 5, and it's working as expected. After installing the module, users can see a helpful message regarding the configuration of the Maxlength module.

Here are the steps I followed:
Install Maxlength module version 2.1.x-dev and check the installation message (adding an SC for reference).
Uninstall the module.
Apply Patch 5 โ†’ and clear the cache.
Reinstall the module and observe the status message.
RTBC+
Thank You.

๐Ÿ‡ฎ๐Ÿ‡ณIndia mayursolaskar

I have applied the !13 MR, and the changes are functioning as expected. The advanced search box now displays full width and looks good on the user interface. I have attached screenshots for small and large screens. RTBC +
Thank You

๐Ÿ‡ฎ๐Ÿ‡ณIndia mayursolaskar

I followed the steps mentioned above, and I was able to reproduce the issue. After applying the #4 patch(applied the patch using composer), the changes worked as expected, resolving the sidebar issue for the Gin theme(Dark Mode). I have added a before & after SC & added a video illustrating the steps I followed. RTBC +
Thank You.

๐Ÿ‡ฎ๐Ÿ‡ณIndia mayursolaskar

The issue mentioned above is reproducible @Abh1shek Chauhan. To address this problem, I made changes in _header.scss file(Added Code SC). However, it's important to note that the Package.json file is missing. We need to include the Package.json file and then compile the SCSS file. After compiling, the changes were reflected in the style.css file.

Original: background: url(../images/icons/search-icon.svg) top right no-repeat;
Modified: background: url(../images/icons/search-icon.svg) right 24px top no-repeat;

By updating the positioning values, I resolved the search and cross-button overlapping issues. I have attached a screenshot for reference. Please review and confirm.
Note:-Before installing the EduX theme, make sure to install the required theme, TheX theme.
Thank you.

๐Ÿ‡ฎ๐Ÿ‡ณIndia mayursolaskar

I followed the steps provided by @djsagar and was able to reproduce the issue. After that, I applied patch #2, which resolved the problem. However, on mobile and iPad screens, I noticed that the search icon is slightly elevated and not centred properly. To address this, Iโ€™ve created a patch that resolves this specific issue.
Thank You

๐Ÿ‡ฎ๐Ÿ‡ณIndia mayursolaskar

The MR !4 mentioned above has been successfully applied. However, this MR works properly when a comment is already added. If there is no comment, the changes are not applied due to the library "(topplus_lite/comment)" not being loaded.
To address this issue, I added the library {{ attach_library('topplus_lite/comment') }} to the "field--comment.html.twig" file, which resolved the problem.
I'm attaching a screenshot for reference.

๐Ÿ‡ฎ๐Ÿ‡ณIndia mayursolaskar

Mediteran theme is associated with the administration theme. The issue with the broken footer menu is specifically related to the default theme. The style of the footer menu is applied based on the default theme and also depends on the region where we add the block. I have tried other default themes as well and have added a screenshot for reference.

๐Ÿ‡ฎ๐Ÿ‡ณIndia mayursolaskar

I reviewed and applied patch #8, and then I applied patch #15 on Drupal 9.5.11-dev. Both patches applied cleanly. The hamburger menu is clickable and working properly (I have added a video for reference).
Additionally, I checked for the Drupal 10.1.1-dev version, and the patch failed to apply there.
Thank You.

๐Ÿ‡ฎ๐Ÿ‡ณIndia mayursolaskar

I applied & reviewed the patch #5, but it failed due to the incorrect path. I applied the changes manually and tested the functionality. During testing, I noticed that on small screens, the search widget and footer menu were overlapping, and when the content is small, the footer was not at the bottom of the page. I have addressed these issues and created a new patch. Please review it.

๐Ÿ‡ฎ๐Ÿ‡ณIndia mayursolaskar

I have attempted to reproduce the reported issue, but I am unable to do so. When I click on the flag text, it opens a popup with a background overlay.please check Screenshot for reference.
Here are the steps I followed for testing:-
Installed and enabled the flag_anon module, ensuring that the required dependency (flag module) was also installed.
Configured the necessary settings for anonymous users as specified in the module.
Accessed the page as an anonymous user and clicked on the flag text,(Login or Register link).
As a result, a popup with a background overlay was displayed.
Thank You

๐Ÿ‡ฎ๐Ÿ‡ณIndia mayursolaskar

I have reviewed this merge request. After applying the MR, the "Read more" button and "Add new comment" are visible on the frontend. However, the admin panel text and submitted user text are not visible due to the color style override. To address this issue, please check the issue Article - Tags links are not visible ๐Ÿ› Article - Tags links are not visible. Needs review . In comment #6 ๐Ÿ› Article - Tags links are not visible. Needs review , I have created MR!12. Thank you

๐Ÿ‡ฎ๐Ÿ‡ณIndia mayursolaskar

Before applying the merge request, the Article tag was not visible. However, after applying the MR, it became visible. But, the admin panel text and submitted user text are not visible due to the override of the color style. To address this issue, I have created a MR !6

๐Ÿ‡ฎ๐Ÿ‡ณIndia mayursolaskar

I have reviewed the merge request (MR) and observed that the deprecated function "file_create_url()" has been updated in the code. Additionally, there were some other deprecated functions that caused errors during the installation of the theme.

Please check on this issue  Unable to upload the Slider image ๐Ÿ› Unable to upload the Slider image Closed: duplicate .
In this issue, we have also updated the above deprecated code and checked the functionality. Functionality is working as expected.

๐Ÿ‡ฎ๐Ÿ‡ณIndia mayursolaskar

Yes, the file_load() function is deprecated and should be updated to the File::load() function.
Please check on this issue Unable to upload the Slider image ๐Ÿ› Unable to upload the Slider image Closed: duplicate
In this issue, we updated the code and checked the functionality. Functionality is working as expected.
Thanks:

๐Ÿ‡ฎ๐Ÿ‡ณIndia mayursolaskar

I have reviewed the above patch, and it applied cleanly. I was able to successfully upload an image. However, I noticed a minor indentation issue in the patch, so I have updated the patch.

Thank You.

๐Ÿ‡ฎ๐Ÿ‡ณIndia mayursolaskar

I observed a change in the primary colour style value (#003CC5). I have updated the hex value to the default primary colour Bootstrap hex value (#0D6EFD) and compiled the SCSS code. Please review.

Thanks:

Production build 0.71.5 2024