- Issue created by @cedewey
- Status changed to Needs review
over 1 year ago 11:14pm 2 August 2023 - last update
over 1 year ago 8 fail - 🇮🇳India sidharth_soman Bangalore
I've added the install hook with the relevant message. Please review this patch.
The last submitted patch, 2: 3378867-2.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- Assigned to samit.310@gmail.com
- Status changed to Needs work
over 1 year ago 12:29pm 18 August 2023 - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 4:37pm 18 August 2023 - last update
over 1 year ago 6 pass - 🇮🇳India mayursolaskar
I have applied Patch 5, and it's working as expected. After installing the module, users can see a helpful message regarding the configuration of the Maxlength module.
Here are the steps I followed:
Install Maxlength module version 2.1.x-dev and check the installation message (adding an SC for reference).
Uninstall the module.
Apply Patch 5 → and clear the cache.
Reinstall the module and observe the status message.
RTBC+
Thank You. - Status changed to Needs work
over 1 year ago 4:09pm 25 August 2023 - 🇺🇸United States cedewey Denver, CO
I've also tested this and it works great. Thanks! One minor, but important change to make is that MaxLength should have the 'l' capitalized.
- Assigned to cedewey
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 8:08pm 25 August 2023 - last update
over 1 year ago 6 pass - 🇺🇸United States cedewey Denver, CO
I've updated the patch to use MaxLength capitalization. This is now ready for review.
- Assigned to hbrokmeier
- 🇺🇸United States cedewey Denver, CO
Assigning to Heather for a final code review.
- Assigned to cedewey
- Status changed to RTBC
about 1 year ago 10:04pm 18 September 2023 - 🇺🇸United States hbrokmeier Wisconsin
Tested & reviewed code, looks good to me!
-
sidharth_soman →
authored 79379c92 on 2.1.x
Issue #3378867 by samit.310@gmail.com, cedewey, sidharth_soman,...
-
sidharth_soman →
authored 79379c92 on 2.1.x
- Status changed to Fixed
about 1 year ago 6:26pm 19 September 2023 - 🇺🇸United States cedewey Denver, CO
Thanks Heather for the review and for everyone who worked on the issue. I also added credit for mlncn for the original suggestion. This has been committed to the 2.1.x branch and will be in the next release of MaxLength. 🎊
Automatically closed - issue fixed for 2 weeks with no activity.