🇺🇸United States @hbrokmeier

I looked into this more, got some advice from the a11y slack and was referred to this article: https://adrianroselli.com/2019/06/link-disclosure-widget-navigation.html....

Based on this a good approach is to use aria-labelledby and reference the link text instead of adding extra hidden text. Aria-expanded already gives context about what the button does, and this is less verbose for screen reader users

<a id="about" href="/about">About</a>
<button aria-labelledby="about" ...></button>

See MR!18, I added level classes to these elements:

• menu__submenu
• menu__item-container
• menu__item-link
• menu__submenu-item-link
• menu__submenu-toggle
• menu__submenu-container

hbrokmeier → created an issue.

hbrokmeier → created an issue.

hbrokmeier → created an issue.

hbrokmeier → created an issue.

🐛 Google Tag manager is loaded without consent Fixed does not solve this issue. When consent mode is enabled in google_tag, consent is hardcoded to `denied`:

  if (config.consentMode === true) {
    gtag('consent', 'default', {
      ad_storage: 'denied',
      analytics_storage: 'denied',
      ad_user_data: 'denied',
      ad_personalization: 'denied',
      wait_for_update: 500,
    });
  }

If the default consent setting in google_tag wasn't hardcoded and could be defined in the module, we could set the default to `granted` and then cookies and google_tag would work nicely together.

hover JS is disabled in this scenario

hbrokmeier → created an issue.

Patch #15 fixed this issue for me as well.

Hi @ivnish, this actually appears to be an issue with Drupal core and not this module, so I'll update the status to Closed (works as designed).

Merge request submitted with the proposed changes:

• Add role="button" to title link
• Add aria-expanded to title link, and update it based on accordion state
• Toggle accordion when space bar is pressed on link

hbrokmeier → created an issue.

@jayhuskins Can this be reopened? The accessibility issue is still present. I've reviewed and tested the merge request and it looks good.

hbrokmeier → created an issue.

hbrokmeier → created an issue.

hbrokmeier → created an issue.

Tested & reviewed code, looks good to me!

This looks like the intended behavior from generating starterkit themes: https://www.drupal.org/project/drupal/issues/3302654 →

It makes sense to include the LightShip readme, but I'm not sure what options we have other than renaming it to something like README.txt so it's included along with the README.md generated by starterkit.

@hipp2bsquare, do you have any ideas for this?

I've pushed my proposed fix for these issues. Thanks!

hbrokmeier → created an issue.

mherchel → credited hbrokmeier → .

Code looks good, and the counting is working correctly for new lines and spaces. There is some inconsistency with how empty lines are counted, but I'm not sure how critical this is. CKE5 counts an empty line as 1 char, CKE4 counts an empty line as 2 chars, and Plain Text fields only count every other empty line.

Tested & reviewed, looks good to go!

cedewey → credited hbrokmeier → .

Looks good to me! Elements with attributes are working and nothing stood out to me in the code review.

I also tested fisherman90's merge request with CKE5, and it looks good, the countdown is working as expected.

hbrokmeier → made their first commit to this issue’s fork.

I ported over some of the template changes that looked useful, added some classes to the main site elements, and updated the readme for the 2.x branch.

hbrokmeier → created an issue.

This depends on the M1 compatibility upgrade commit.

For 3. Compile sass on gulp watch, I set the default gulp task to build & watch.