New lines and spaces are miscounted

re-rolled for 2.1.x

After reading through the issue, I have a couple of points that I don't understand.

1. We have tests where we test new lines with

What I don't understand, why are we using "\r" as replacement if wherever I check it, should be "\n" or for Win systems "\r\n" pair?

I tested spaces and they are perfectly fine for me over both wysiwyg and none wisywyg as our automated tests show as well, since that part is covered.

I've tested this manually and can confirm that new lines and spaces are being counted properly on CKEditor fields.

Assigning to Heather to do a final code review. If this merge request passes her review, then this can be marked Reviewed and Tested by Community.

@cedewey, @hbrokmeier I think wysiwyg field will be fine because there new lines are often marked by the respective HTML tag
or .
I will have to implement some sort of test for text fields without wsywiyg, so actually the "\r\n" will be used for new lines and line breaks. We have to test the same manually.

Code looks good, and the counting is working correctly for new lines and spaces. There is some inconsistency with how empty lines are counted, but I'm not sure how critical this is. CKE5 counts an empty line as 1 char, CKE4 counts an empty line as 2 chars, and Plain Text fields only count every other empty line.

Hi @joevagyok,

I'm ok with the slight discrepancies in counts between CKEditor 5, CKEditor 4 and plain text. CKEditor 4 is being deprecated and the count difference is marginal.

Marking this RTBC. If any of the maintainers believe this needs more work, please speak up by the end of the week.

Thank you all!

Automatically closed - issue fixed for 2 weeks with no activity.