- Issue created by @joevagyok
- @joevagyok opened merge request.
- 🇧🇪Belgium joevagyok
Introduced additional test case for CKEditor 4 version, since we support both D9 and D10 I need to make a version comparison to not run CKEditor 4 test in D10 since the module is not in place. I had to rename the helper functions in order to introduce the same helper functions for CKEditor4.
I pushed the test that should fail without the fix. In the next commit I will push the fix and test should pass.
- 🇧🇪Belgium joevagyok
For some reason the JS alert doesn't produce exception over drupal CI. On my local I have the test failing as expected.
- 🇧🇪Belgium joevagyok
I pushed the fix that will prevent the removal of the actual html tag since we already prevent self-closing tags to be added to the open_tags stack in JS. This caused to remove the opening html tag due to a self-closing tag that was detected based on "/>" characters before we handled self-closing tags based on an array list, resulting in the alter message.
- Status changed to Needs review
almost 2 years ago 2:24pm 9 March 2023 - Assigned to hbrokmeier
- 🇺🇸United States cedewey Denver, CO
I've tested the merge request and can confirm it works as expected. Assigning to Heather to do a final code review.
- Assigned to joevagyok
- Status changed to RTBC
almost 2 years ago 4:45pm 29 March 2023 - 🇺🇸United States hbrokmeier Wisconsin
Tested & reviewed, looks good to go!
- Status changed to Fixed
almost 2 years ago 9:27am 30 March 2023 -
joevagyok →
committed eb8c71fb on 2.1.x
Issue #3346927 by joevagyok, cedewey, hbrokmeier: Self-closing tags with...
-
joevagyok →
committed eb8c71fb on 2.1.x
Automatically closed - issue fixed for 2 weeks with no activity.