- Issue created by @coaston
- Status changed to Needs review
about 1 year ago 11:47pm 25 August 2023 - 🇦🇷Argentina tguerineau
In order to address the issue I made a patch.
Patch Description:
This patch addresses the visual discrepancies between the default textarea and the CKEditor appearance when different text formats are selected. The proposed changes ensure a cohesive and harmonized visual experience across various text formats.
Changes Made:
1. Updated CKEditor background, text color, font size, and weight to match the textarea styles for consistency.
2. Adjusted the focus border color of CKEditor to align with other form elements.Test made:
- Ensured the styles look appropriate across different viewports.
- Checked the visual appearance of various CKEditor buttons and functionalities for consistency.Feedback:
Given that these are visual changes, I'd appreciate feedback on the aesthetics. Please review the updated CKEditor appearance and let me know if further refinements are required.
- Status changed to Needs work
about 1 year ago 3:01am 28 August 2023 - 🇺🇸United States baldwinlouie
@tguerineau, thank you for the patch and your effort to fix this. Can I ask you for two things
1. Please create an issue fork and check your code into the fork. Once your code is checked in, please open a Merge Request.
2. The theme is using SCSS files and the main.css is compiled from the SCSS files. You will find them under
rigel/assets/scss
. We have instructions on how to compile the main.css using the SCSS files. You can review the instructions here: https://git.drupalcode.org/project/rigel/-/blob/6.x/README.md . You will be checking in the SCSS file and also the main.css file into the Merge Request. - @tguerineau opened merge request.
- Status changed to Needs review
about 1 year ago 7:39pm 28 August 2023 - 🇦🇷Argentina tguerineau
Thank you for the feedback.
I made the following changes:
1. I have created an issue fork and opened a Merge Request for it. I apologize for the oversight – I mistakenly created three branches in the process. I've opened a Pull Request for the correct branch, and I'll ensure to be more careful in the future. Please let me know if there's any cleanup needed on my end regarding the extra branches.
2. I've made the necessary changes to the SCSS files as you pointed out, compiled them, and both the SCSS and main.css files have been updated in the Merge Request.
Let me know if there are any additional changes or adjustments needed.
Thanks again for your guidance and patience.
- 🇮🇳India mayursolaskar
Thank you, @tguerineau. I have applied the MR !31, and the changes are working as expected. The comment is now visible to users and the comment box is also in dark mode. I have attached a screenshot for your reference.RTBC+
Thank You. - 🇦🇷Argentina tguerineau
Issue Update: 3383327
I'd like to apologize for the oversight in my previous commit. I mistakenly pushed changes for this issue to a branch intended for a different issue within the same contrib theme.
Actions Taken:
I've pushed a new commit to revert the unintended changes.
The branch now only contains changes relevant to the "Comments color" issue.
I understand the importance of maintaining clarity in version control, especially in collaborative projects. Please review the updated changes and let me know if there are any concerns.Thank you for your understanding.
- Status changed to RTBC
about 1 year ago 2:40am 29 August 2023 - 🇺🇸United States baldwinlouie
@tguerineau Thank you for the work on this patch! I applied it and it fixes the issue with Comment colors. Here is a screenshot from my test.
I think this is +RTBC
- First commit to issue fork.
- @yas opened merge request.
- @yas opened merge request.
- 🇺🇸United States yas California 🇺🇸
@baldwinlouie
Thank you for your review.
@tguerineau
Thank you for fixing the issue. It looks good to me, too. I'll merge the patch to
6.x
, and close this issue as Fixed.Note: no worries for your unused branches. I opened the MR for those branches and closed them immediately. Then those are not shown as hidden branches.
-
yas →
committed 0eeebffa on 6.x authored by
tguerineau →
Issue #3383327 by tguerineau, yas, baldwinlouie, coaston, mayursolaskar...
-
yas →
committed 0eeebffa on 6.x authored by
tguerineau →
- Status changed to Fixed
about 1 year ago 6:21am 29 August 2023 - 🇺🇸United States baldwinlouie
@yas, FYI, this merge wiped out the changes from https://www.drupal.org/project/rigel/issues/3382347 🐛 Fix table header color for unsortable headers Fixed .
I'll re-add those changes back when I check in the changes for https://www.drupal.org/project/rigel/issues/3384345 📌 Change clickable table headers to use blue text color Fixed
Automatically closed - issue fixed for 2 weeks with no activity.