Fix table header color for unsortable headers

Created on 21 August 2023, over 1 year ago
Updated 29 August 2023, about 1 year ago

Problem/Motivation

  • If a table header is unsorted, it is really hard to read. Fix the text color.
πŸ› Bug report
Status

Fixed

Version

6.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States baldwinlouie

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @baldwinlouie
  • πŸ‡ΈπŸ‡°Slovakia coaston

    +1

    attached.

  • @tguerineau opened merge request.
  • First commit to issue fork.
  • Status changed to Needs review about 1 year ago
  • πŸ‡¦πŸ‡·Argentina tguerineau

    In order to address the issue I made a commit.

    Proposed Solution: I've addressed the table header color issue by increasing the CSS specificity for the affected styles. In order to ensure compatibility with various use cases and avoid potential regressions, I've retained the existing !important declarations for now. However, with the increased specificity, some of these might be redundant. It would be worthwhile to have a follow-up issue to assess and potentially clean up any unnecessary !important declarations.

    Changes Made:

    - Updated the CSS selector from table { to table.table { to increase specificity.
    - Retained existing !important declarations for safety.

    Testing: The changes have been tested locally in various scenarios, and everything seems to function as expected. I'd appreciate feedback.

  • Status changed to RTBC about 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States baldwinlouie

    @tguerineau Thank you for the patch. I tested it in my environment and it fixes the issue! I will mark this RTBC. Your suggestion for cleaning up !important is a good process as well.

    Just curious, are you using this theme for any of your projects?

  • πŸ‡ΊπŸ‡ΈUnited States yas California πŸ‡ΊπŸ‡Έ

    @baldwinlouie

    Thank you for your review.

    @tguerineau

    Thank you for the patch. It looks good to me, too. I'll merge the patch to 6.x, and close this issue as Fixed.

  • Status changed to Fixed about 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States yas California πŸ‡ΊπŸ‡Έ
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024