- Issue created by @baldwinlouie
- @tguerineau opened merge request.
- First commit to issue fork.
- Status changed to Needs review
about 1 year ago 10:30pm 28 August 2023 - π¦π·Argentina tguerineau
In order to address the issue I made a commit.
Proposed Solution: I've addressed the table header color issue by increasing the CSS specificity for the affected styles. In order to ensure compatibility with various use cases and avoid potential regressions, I've retained the existing
!important
declarations for now. However, with the increased specificity, some of these might be redundant. It would be worthwhile to have a follow-up issue to assess and potentially clean up any unnecessary !important declarations.Changes Made:
- Updated the CSS selector from
table {
totable.table {
to increase specificity.
- Retained existing!important
declarations for safety.Testing: The changes have been tested locally in various scenarios, and everything seems to function as expected. I'd appreciate feedback.
- Status changed to RTBC
about 1 year ago 2:12am 29 August 2023 - πΊπΈUnited States baldwinlouie
@tguerineau Thank you for the patch. I tested it in my environment and it fixes the issue! I will mark this RTBC. Your suggestion for cleaning up
!important
is a good process as well.Just curious, are you using this theme for any of your projects?
- πΊπΈUnited States yas California πΊπΈ
@baldwinlouie
Thank you for your review.
@tguerineau
Thank you for the patch. It looks good to me, too. I'll merge the patch to
6.x
, and close this issue as Fixed. -
yas β
committed 876a41ef on 6.x authored by
tguerineau β
Issue #3382347 by tguerineau, baldwinlouie, coaston, yas: Fix table...
-
yas β
committed 876a41ef on 6.x authored by
tguerineau β
- Status changed to Fixed
about 1 year ago 6:21am 29 August 2023 Automatically closed - issue fixed for 2 weeks with no activity.