- Issue created by @Tirupati_Singh
- Merge request !40Issue #3470486: Added new field widget configuration for displaying similar... → (Open) created by Tirupati_Singh
- Issue was unassigned.
- Status changed to Needs review
5 months ago 2:12pm 27 August 2024 - 🇮🇳India Tirupati_Singh
Hi, I've provided a new configuration option for enabling/disabling the design for single value select field similar to the multiple value select field. I've attached the screenshots for reference. Please review the MR.
Hello @tirupati_singh,
I've reviewed the MR!40 and found you have included the styling for gin, claro and seven theme in the newly created file select2.single-style.scss however separate scss files are present for these theme styling. IMO we could maintain the discrete structure of styling as present in the module.
I installed the module and followed the steps mentioned in the issue. Encountered the design inconsistency therefore applied your patch. The design of single list item was improved after enabling the checkbox in the field widget present in Manage Form Display page and now it matches the multi-select list item design. I verified the design in seven, claro and gin admin themes. I noticed few issues in case of seven theme. The style for the single list item seems to be different compared to the multi-select list item and the alignment of the dropdown button is inappropriate. It would be nice if we could makes these updates thus moving it to NW.
NOTE: After installing the module we need to follow the steps mentioned in modules project page → to integrate the select2 library.
Attaching ss for reference.
Thanks- 🇮🇳India Tirupati_Singh
Hi @esha_kundu, I've fixed the design issue of single item list for seven. I've attached the screenshot of after fixes. Please review the changes.
I've reviewed the MR!40 and found you have included the styling for gin, claro and seven theme in the newly created file select2.single-style.scss however separate scss files are present for these theme styling. IMO we could maintain the discrete structure of styling as present in the module.
The reason why I included the styling in one file and not the existing files is because a new library is being attached with the
Single item style
widget when this functionality is enabled. If the change was to be kept in the existing file, the CSS would load even if theSingle item style
option was disabled. Thanks @tirupati_singh for addressing the issues that I had mentioned in #4 ✨ Display design similar to multiple selected values when the select field allows single value. Active earlier. I re-reviewed the MR!40 and it looks good to me. I applied the patch which applied cleanly after that I configured the admin theme to seven. In Manage Form Display enabled the checkbox in the field widget and verified the design for the single select field elements. The alignment and design for the single select field items was improved.
I've reviewed the MR!40 and found you have included the styling for gin, claro and seven theme in the newly created file select2.single-style.scss however separate scss files are present for these theme styling. IMO we could maintain the discrete structure of styling as present in the module.
Regarding this suggestion that I mentioned earlier, thanks for the clarification and I acknowledge that unnecessary css should be avoided loading on a page when the Single item style option is disabled.
Including ss for the after changes. Moving to RTBC.
Thanks