- Issue created by @alok_singh
Hello,
I installed the theme in Drupal 10.4.0 version.
Visited the/search/node
page and found the serach input box is not visible.
Applied the provided MR!3, which applied cleanly.
On revisiting the/search/node
page the search input box was visible.
However, it seems variables are being used in the theme for color/background property. Also I noticed that the below border snippet is already present in form_input.css fileborder: var(--button-border); border-radius: var(--radius);
Just that the width, style and border color are not defined for the border property. As per my findings the %form_element placeholder in form_input.scss seems to be also not defined anywhere and most likely the above css properties were suppose to be defined in this placeholder due to which this issue might have occurred. IMO we can try to replace the current hex value used for the border color with variables. Attaching ss for before and after. Thus, moving to NW.
For a better solution we would be glad to hear from @tomsaw.
Thanks- 🇮🇳India chhavi.sharma
Modified the changes as adviced by @esha_kundu. The changes need review.
- Status changed to Needs work
about 1 month ago 11:22am 28 May 2025 Hello @chhavi.sharma,
I've reviewed the changes in the MR!3, variables has been added as per my last comment. However, it seems like you have missed the point about the variables being undefined. Now after the patch is being applied due to undefined variables the style is not getting applied hence the issue isn't resolved.
It would be better if you defined the undefined variables in the form_input.scss file similar to that of
--lum: var(--lum-body);
and for the border-color you could follow border-color property defined in base.scss for the hr tag.
I would also recommend to use different variable name instead of --button-border, cause to resolve this issue we are defining the variable specifically in form_input.scss file.
Moving to NW. Thanks