- Issue created by @alok_singh
- First commit to issue fork.
- Merge request !12Spacing issue has been resolved below the login, create new account and reset your password pages โ (Merged) created by jaydeep_patel
- Status changed to Needs review
4 months ago 10:30am 22 August 2024 - ๐ฎ๐ณIndia jaydeep_patel Ahmedabad
Spacing issue has been resolved below the login, create new account and reset your password pages. Attached the screenshot for reference.
Thank you
- ๐ฎ๐ณIndia riddhi.addweb
Without applying the patch the issue looks resolved. Also before and after applying the patch the issue looks the same. But If the patch is not applied then, the issue looks resolved. Attaching the SS for the same.
- ๐ฎ๐ณIndia dishakatariya
Hi, I have also checked this issue, but it already looks good to me even without applying the patch.
Attaching the screenshots for reference.
Thanks! - ๐ฎ๐ณIndia ravi kant Jaipur
ravi kant โ made their first commit to this issueโs fork.
- ๐ฎ๐ณIndia ravi kant Jaipur
The issue was due to gap was not added between main content and footer content. Also the comment section was adding space when comment section was not rendering.
Hello @ravi kant,
I encountered this issue when I cloned the repo and checked in the development version 1.0.x-dev however when the theme is installed using composer from the project page the spacing issue is not found. After installing the theme I visited the login, register, reset password pages. I faced the mentioned issue. For Article content type when the comment section is placed at the end page by configuring in Manage Display, an extra spacing is noticed if the comment section is not rendering. I applied the MR!12 which applied cleanly. I revisited the pages (login, register, reset password, article content type pages, page where comment section is not rendering) the spacing issue was resolved. I've also reviewed the MR and it looked good to me.
Attaching the ss for reference and moving to RTBC.
Thanks :)- ๐ฎ๐ณIndia ravi kant Jaipur
Thank you everybody to work on this ticket.
Automatically closed - issue fixed for 2 weeks with no activity.