- Issue created by @alok_singh
- Merge request !3governor-34646544: In Add new comment, save and preview button needs space. → (Open) created by alok_singh
- Status changed to Needs review
11 months ago 4:40am 31 July 2024 - Status changed to Needs work
11 months ago 10:19am 6 August 2024 - 🇮🇳India riddhi.addweb
I have applied the MR !3 cleanly but still, the style is not updated.
Please check the screenshot for the same. - Assigned to Tanushree Gupta
- Merge request !10Issue 3464654: Added space from top and bottom of save and preview buttons. → (Open) created by Tanushree Gupta
I have added space above and below the buttons, but the issue in this theme is with the CSS. The CSS file does not exist here, which may be causing the problem. However, once gulp runs and the CSS is generated, the added space above and below the buttons will be visible.
Here is the MR: https://git.drupalcode.org/project/governor/-/merge_requests/10- Issue was unassigned.
Hello @tanushree Gupta,
I have reviewed MR!10, and it appears that all the form items are getting targeted. Could we make this a bit more specific? I installed the theme on Drupal version 10.4.0, and following the "Getting Started" steps provided in the theme's readme.md file, I encountered the mentioned issue in the "Add Comment" section.
I applied MR!10, which integrated cleanly, and then followed the steps to compile the CSS changes. While the spacing between the form's subject and body looks good, there seems to be too much space above the comment form buttons. Additionally, the form overflows on mobile devices. I am attaching a screenshot for reference.
Therefore, moving this to NW.
Thank you!