- 🇺🇸United States mlncn Minneapolis, MN, USA
Patch has a ton of unrelated formatting changes (and deletes the CSS?) but i think i see the part that's wanted and
New fixes are going in 3.0.x which is a drop-in replacement for 8.x-1.x; for now the main differences are these fixes (and breakpoints matching Bulma's, maybe review that change's impact on your subtheme).
-
MegaKeegMan →
committed 5f2ece48 on 8.x-1.x
Issue #3253015 by Dharti Patel, shweta__sharma, mlncn: On mobile links...
-
MegaKeegMan →
committed 5f2ece48 on 8.x-1.x
- Status changed to Needs review
5 months ago 4:10am 19 July 2024 - 🇺🇸United States mlncn Minneapolis, MN, USA
Same fix in both 3.0.x and 8.x-1.x, please review!
- Status changed to RTBC
3 months ago 12:42pm 9 September 2024 Hello,
I've reviewed the changes by following the below steps:- Installed the theme version 8.x-1.0 in Drupal version 10.3.2, found the overflowing issue on mobile devices. (The theme version 8.x-1.0 is a tag that doesn't consists of the new changes).
- As the changes have been merged in development branches 3.0.x and 8.x-1.x, therefore I removed the theme (installed using composer version 8.x-1.0) and cloned the project from git.
- In branch 8.x-1.x, installed and enabled the theme. The overflow issue was resolved.
- Then, I changed to branch 3.0.x and created a sub-theme followed by enabling the sub-theme. The issue was resolved in this as well.
Including the before and after ss for reference.
Hence, moving to RTBC.
Thanks