- Issue created by @alok_singh
- Merge request !74rigel-3483051a: On Searched page, Search button is not visible. → (Merged) created by alok_singh
- 🇺🇸United States yas California 🇺🇸
@alok_singh
Thank you for supplying the patch. I posted my minor comment. Thanks!
Hello @yas,
I've resolved the minor comment that you had added in the MR!74. I found the hover effect for this search button is different from the buttons present in theme hence fixed the hover effect for the search button. While I reviewed the MR!74 I came across that the variable was not used for the color property therefore replaced the hex-value for color with the variable. Attached video for the hover effect.
Please have a look.
Thanks- 🇺🇸United States yas California 🇺🇸
@esha_kundu
Thank you for taking care of the issue. Can you please fix the conflicts after merging 🐛 Read more and add new comment need to be styled. Active ? Also, can you fix the Stylelint errors at https://git.drupalcode.org/issue/rigel-3483051/-/jobs/3269077?
Please see also at the README.md about how to do it.
Thanks!
@yas sorry for too many commits but I've resolved the conflicts and also fixed the Stylelint errors that were present.
Please have a look. Thanks- 🇮🇳India jaydeep_patel Ahmedabad
I have tested this issue. MR!74 applied successfully and issue has been fixed, Search button and it's hover effect is looks good now. So moving it to RTBC.
Thank you!!
- 🇺🇸United States yas California 🇺🇸
@esha_kundu
Thank you for the fix.
@jaydeep_patel
Thank you for your review.
I’ll merge the patch into
7.x
and8.x
; and close this issue as Fixed. -
yas →
committed 6bcb138f on 8.x authored by
alok_singh →
Issue #3483051 by esha_kundu, alok_singh, yas, jaydeep_patel: Fix to...
-
yas →
committed 6bcb138f on 8.x authored by
alok_singh →
-
yas →
committed 109e3093 on 7.x authored by
esha_kundu →
Issue #3483051 by esha_kundu, alok_singh, yas, jaydeep_patel: Fix to...
-
yas →
committed 109e3093 on 7.x authored by
esha_kundu →
Automatically closed - issue fixed for 2 weeks with no activity.