Account created on 30 October 2014, about 10 years ago
  • Tech Lead | Drupal Frontend at TO THE NEWย  โ€ฆ
#

Recent comments

๐Ÿ‡ฎ๐Ÿ‡ณIndia amit.mall

Adding negative margin on ul from left side will fix the issue. Patch is attached

๐Ÿ‡ฎ๐Ÿ‡ณIndia amit.mall

use the attached patch. Also some css code directly pushed in css file, instead of scss. This patch will fixed that as well.

๐Ÿ‡ฎ๐Ÿ‡ณIndia amit.mall

patch is attached for this

๐Ÿ‡ฎ๐Ÿ‡ณIndia amit.mall

@cafuego, overding color will not solve the issue in all cases, since we have made that section configrable from backend. So it's better not to change color of active tab. I have add exclude the active tab for color change, this will solve the issue. Find the patch for same

๐Ÿ‡ฎ๐Ÿ‡ณIndia amit.mall

@radheymkumar patch not working

๐Ÿ‡ฎ๐Ÿ‡ณIndia amit.mall

amit.mall โ†’ changed the visibility of the branch 3424275-optimize-code-and to hidden.

๐Ÿ‡ฎ๐Ÿ‡ณIndia amit.mall

this has been added

๐Ÿ‡ฎ๐Ÿ‡ณIndia amit.mall

amit.mall โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia amit.mall

so this is a placeholder, you can write css for placeholder at own.

::-ms-input-placeholder { /* Edge 12-18 */
  color: red;
}

::placeholder {
  color: red;
}
๐Ÿ‡ฎ๐Ÿ‡ณIndia amit.mall

I have added a patch for this, with variable z-index. Use the attched patch: 3426402.patch

๐Ÿ‡ฎ๐Ÿ‡ณIndia amit.mall

@mglaman, your are right. we can add variable, also Now I have added the code inside source files as well

๐Ÿ‡ฎ๐Ÿ‡ณIndia amit.mall

I have added a patch (3423033.patch) for this, this should work.

๐Ÿ‡ฎ๐Ÿ‡ณIndia amit.mall

since some core themes moved to contrib folder, in D10, changing the condition to "override templates only if not already overrided by default theme"
use patch 3410963.patch, should fix the issue

๐Ÿ‡ฎ๐Ÿ‡ณIndia amit.mall

Although this has been fixed into latest release, if you still want to use the old one, use the attached patch

๐Ÿ‡ฎ๐Ÿ‡ณIndia amit.mall

not sure how you creating, but youtube video comes in iframe, and iframe tag not supported into views.

๐Ÿ‡ฎ๐Ÿ‡ณIndia amit.mall

I think there is already an service by name "X" so we can simply replace twitter with x.

๐Ÿ‡ฎ๐Ÿ‡ณIndia amit.mall

@adm_b โ†’ Popup width is dependent on image size, and you can set the image size by adding an image style on popup image. follow the steps:

  1. Go to the content type, where your image is used
  2. Go to the Manage display tab
  3. on Format dropdown you select Image Popup
  4. Click on setting option, and go to Image Popup, and select your image style inside Popup Image style dropdown.
  5. Now Popup will match the dimensions of the image you set inside image style
๐Ÿ‡ฎ๐Ÿ‡ณIndia amit.mall

@shiv_yadav @shweta__sharma shifting button to left is not a proper solution, since it changes the UI. Also on small screen lets say 420px the button and text got hidden. We have to make sure there is enough height of the image to hold the content. I'm attaching the patch, this will fix the all issue on mobile, keeping the button in center.

๐Ÿ‡ฎ๐Ÿ‡ณIndia amit.mall

I think this is not in center even on desktop, because there is left property by 1.25rem. we can remove this. Use the patch 3387234.patch, and run the gulp command, to generate the css. This should fix the issue

๐Ÿ‡ฎ๐Ÿ‡ณIndia amit.mall

I can reproduced this issue also when using this theme as "Administration theme". I think we should use min-height instead of height for html,body,.wrapper in style.css. I have attach the patch [365621.patch] for this. This should fix the issue on both, frontend and backend

๐Ÿ‡ฎ๐Ÿ‡ณIndia amit.mall

@shiv_yadav although I can't see Drupal Admin LTE theme in your screenshot, using sidebar menu, but looks like issue is not part of "Drupal Admin LTE theme" it's working fine, it was my mistake, I was verifying this on https://adminlte.io/themes/v3/

๐Ÿ‡ฎ๐Ÿ‡ณIndia amit.mall

@shiv_yadav I'm talking about Drupal Admin LTE theme, looks like you are checking this on default theme

๐Ÿ‡ฎ๐Ÿ‡ณIndia amit.mall

amit.mall โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia amit.mall

you can add a click handler on that "Load More" button. so clicking on that button run the following js code:
$('#your-slider').slick('refresh');

๐Ÿ‡ฎ๐Ÿ‡ณIndia amit.mall

I have added white color for hovered menu, use the patch 3357993.patch

๐Ÿ‡ฎ๐Ÿ‡ณIndia amit.mall

amit.mall โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia amit.mall

incomplete information, please let us know, how you are using claro theme, as admin theme or frontend theme? if your Menu not displayed completely or menu in dropdown is not displaying?

Production build 0.71.5 2024