Claro off-canvas dialog styling issues and inconsistencies

amit.mall → made their first commit to this issue’s fork.

Hi,
I attempted to recreate the problem using Core 11.x and the admin_dialog module, but unfortunately, that module is not compatible with Core. However, I was able to replicate the issue using Core 10.0.x with the module.

I was able to replicating issue with version 10.0.x and plz review the path

1. I have added space" and for the double time printing Revision information " This is the Drupal core functionality."
2. Vertical space issue for Filter wrapper is fixed
3. "Save" button theming is done

I made an attempt to reproduce the issue with Drupal Core 11.x along with the admin_dialog module. but unfortunately, that module is not compatible with D11, However, I was able to replicate the issue using Core 10.0.x with the module As instructed in the IS, I successfully installed a new instance of Drupal 10.0.x. Afterward, I proceeded to install the Admin Dialogs module. Once the module was installed, I applied patch #6 (3360933_6.patch) without encountering any errors. The patch was successfully applied.

These are the following things fixed by the patch:
1. Spaced added between information and No revision text in the "Revision informationNo revision" summary filed
2. Save button styling got fixed.

The duplicate text of "Revision informationNo revision" issue still exists post applying the patch.
Attaching a screenshot after applying the patch for reference .

Hello dsandhya,
Upon reviewing your patch #6, I noticed that you have used the "!important" declaration in multiple instances. It is important to note that relying heavily on "!important" is not considered good practice according to CSS guidelines. In light of this, I have created a revised patch that eliminates the use of "!important".

Extra point cover:-
1. div.filter-help should be floating right point

Note : The duplicate text of "Revision informationNo revision" issue remain because it's Drupal core functionality.

The last submitted patch, 8: off-canvas-dialog-styling-issues-and-inconsistencies-3360933-8.patch, failed testing. View results →

Issue summary should be updated with proposed solution.

1. Updated the Issue summary with proposed solution.
2. #8 patch found the random failure, restoring the status to need review.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Gauravvvv → changed the visibility of the branch 3360933-claro-off-canvas-dialog to hidden.

Gauravvvv → changed the visibility of the branch 3360933-claro-off-canvas-dialog to hidden.

Gauravvvv → changed the visibility of the branch 3360933-claro-off-canvas to hidden.

Appears to be missing the User interface section, but should have before/after screenshots. Also need to be reproduced without a contrib module.