- Issue created by @mglaman
- ๐ฎ๐ณIndia amit.mall
I have added a patch (3423033.patch) for this, this should work.
- Status changed to Needs review
10 months ago 6:00pm 26 February 2024 - ๐บ๐ธUnited States mglaman WI, USA
+++ b/dist/css/base/gin.css @@ -4489,3 +4489,10 @@ blockquote::before { + margin-top: 0.3rem ... + margin-top: 0
Does Gin have existing CSS variables which could be used here?
Also, this didn't update the source files only compiled CSS
- ๐ฎ๐ณIndia amit.mall
@mglaman, your are right. we can add variable, also Now I have added the code inside source files as well
- Assigned to djsagar
- ๐บ๐ธUnited States mglaman WI, USA
thanks @amit.mall I'll find some time to test this week :)
- ๐ฎ๐ณIndia djsagar
Tested Patch #5 in drupal 10.2.2.
Result:
After patch missing bottom border is added.
Other issues which i found,
Table sticky thead overlap sticky page title.
Patch files are no longer recommended so please create MR.
- Issue was unassigned.
- Assigned to Kanchan Bhogade
- Issue was unassigned.
- ๐ฎ๐ณIndia Kanchan Bhogade
Hi
I've tested patch 3423033_2 on Drupal 10.2
The patch was applied successfully...Test Result:
The Bottom border is added for the Filter.RTBC+1
Attaching screenshots for references
Keeping in "needs review" for code verification
- ๐ฎ๐ณIndia deepanshu.varshney
deepanshu.varshney โ made their first commit to this issueโs fork.
- Assigned to deepanshu.varshney
- Status changed to Needs work
10 months ago 5:55am 7 March 2024 - ๐ฎ๐ณIndia deepanshu.varshney
For border bottom issue is resolved after applying patch 3423033_2. but the Table sticky thead overlap sticky page title are not resolved so I worked on that issue.
- Merge request !3913423033:Fixed table sticky overlap page title. โ (Merged) created by deepanshu.varshney
- Issue was unassigned.
- Status changed to Needs review
10 months ago 7:01am 7 March 2024 - ๐ฎ๐ณIndia deepanshu.varshney
I have fixed the table sticky thead overlap sticky page title and added the border bottom issue code in MR.
- ๐ฎ๐ณIndia Kanchan Bhogade
Hi
I've tested for MR !391 on Drupal version 10.2
The patch applied cleanly...Test result:
The Bottom border was added for the permission filter and the Table header is stickyAdded video for reference
RTBC+1
- Status changed to RTBC
9 months ago 12:36pm 13 March 2024 - First commit to issue fork.
- Status changed to Fixed
9 months ago 12:17pm 28 March 2024 - ๐จ๐ญSwitzerland saschaeggi Zurich
Thanks y'all, I've pushed some improvements to isolate the filter on the top similar to other views.
Automatically closed - issue fixed for 2 weeks with no activity.