Coding Standard Issues

Open on Drupal.org →

Created on 25 October 2024, 28 days ago

Problem/Motivation

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css .

FILE: .../web/modules/custom/helpfulness/src/Form/HelpfulnessBlockForm.php
-------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormBase.
-------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------

FILE: .../web/modules/custom/helpfulness/src/Form/HelpfulnessConfirmDeleteFeedbackForm.php
--------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\ConfirmFormBase.
--------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------

FILE: .../web/modules/custom/helpfulness/src/Form/HelpfulnessReportForm.php
-------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormBase.
-------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------

FILE: .../web/modules/custom/helpfulness/src/Plugin/Block/HelpfulnessBlock.php
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Plugin\ContainerFactoryPluginInterface.
--------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------

Steps to reproduce

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css .

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task

Status

Active

Version

2.0

Component

Code

Created by

🇵🇪Peru alyaj2a

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!4Coding Standard Issues
Open
🇵🇪Peru alyaj2a
updated 26 days ago
!5Coding Standard Issues
Open
🇮🇹Italy apaderno
updated 26 days ago

Comments & Activities

Issue created by @alyaj2a
Comment 28 days ago →
🇵🇪Peru alyaj2a
Merge request !4Coding Standard issues - #3483517 → (Open) created by alyaj2a
Comment 28 days ago →
🇵🇪Peru alyaj2a

Comment 28 days ago →

🇵🇭Philippines paraderojether

Hi

I reviewed MR!4, applied it against the helpfulness 2.x-dev, and confirmed it fixes the issues reported by phpcs.

helpfulness git:(2.x) curl https://git.drupalcode.org/project/helpfulness/-/merge_requests/4.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2611    0  2611    0     0    775      0 --:--:--  0:00:03 --:--:--   778
patching file 'src/Form/HelpfulnessBlockForm.php'
patching file 'src/Form/HelpfulnessConfirmDeleteFeedbackForm.php'
patching file 'src/Form/HelpfulnessReportForm.php'
patching file 'src/Plugin/Block/HelpfulnessBlock.php'
➜  helpfulness git:(2.x) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig helpfulness
➜  contrib git:(main) ✗

Thank you.

Comment 26 days ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
avpaderno → made their first commit to this issue’s fork.
Merge request !5Created a new merge request to get the list of all the PHP_CodeSniffer errors/warnings to fix → (Open) created by apaderno
Pipeline finished with Success
26 days ago
Total: 135s
#322406
Comment 26 days ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
Comment 26 days ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
avpaderno → changed the visibility of the branch 3483517-gitlab-ci-reports to hidden.
Pipeline finished with Success
26 days ago
Total: 207s
#322409

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024