Custom action similar to drd actions

Created on 13 November 2023, about 1 year ago

Problem/Motivation

For custom actions it seems that the PHP code is based to the remote site, meaning your class is not really a class but just a PHP script.

Steps to reproduce

Proposed resolution

Add an option to treat custom actions the same way as drd / drd_agent actions are treated.

Remaining tasks

Add code

User interface changes

None, config will be set in settings.php

API changes

None

Data model changes

None

Feature request
Status

Closed: won't fix

Version

4.1

Component

Code

Created by

🇧🇪Belgium attiks

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @attiks
  • 🇧🇪Belgium attiks

    MR created

    For settings.php you can use the following

    $settings['drd.trusted_modules'] = [
      'ocha_drd',
    ];
    
    

    Only problem left is how and where to display the output

  • Status changed to Needs review about 1 year ago
  • 🇧🇪Belgium attiks

    To NR to get feedback

  • 🇩🇪Germany jurgenhaas Gottmadingen

    I'm not sure what the problem should be, that this is trying to solve. Can you please explain in more detail? What is that about a class vs a script and why do we need a setting for trusted modules?

  • 🇧🇪Belgium attiks

    The idea is to disable passing PHP code from the DRD site to the remote sites, so only code on disk (on the remote site) can be executed.

    In the case the DRD site get hacked, it will be able to pass and execute any PHP code on the client sites, OPS people don't like it.

    About the name "trusted_modules", it can be changed, but that was the best I could come up with

  • Status changed to Closed: won't fix about 1 year ago
  • 🇩🇪Germany jurgenhaas Gottmadingen

    If there is any reason to believe that a DRD site could have been hacked, then there is everything at risk. The DRD site should not be publicly available, as it has full control over remote sites. That's what you accept when you grant admin access to DRD while adding a new remote site.

    There had been security considerations in the past and also a couple of issue about this topic. There is no intention to change the approach on this.

Production build 0.71.5 2024