- Issue created by @kuhikar
- Assigned to jcnventura
- 🇧🇪Belgium attiks
See discussion in https://www.drupal.org/project/ga_login/issues/3297284#comment-14716408 →
> Setting to fixed, as this module is going to be absorbed back into tfa.
All in favor of moving to tfa module, no need for duplication
- Status changed to Closed: won't fix
9 months ago 1:52pm 18 December 2023 - 🇵🇹Portugal jcnventura
I find this request strange. The module page, and both the releases of the tfa and ga_login module explain clearly that this module has been merged into the tfa module since last year ( 📌 Merge ga_login module Fixed ). Anyone actually "working on ga_login of Drupal 9" would clearly see that this module is now only a shell with a info.yml.file marking it as obsolete.
The module homepage clearly states:
"Drupal 8 and 9 - NO LONGER SUPPORTED!The Drupal 8 and 9 version of this module used to provide a TOTP/HOTP plugin for the Two-Factor Authenticator module.
That functionality has been merged into that module, and removed from this one, emptying it completely. It is recommended to remove this module from any running site, and use instead an updated version of the TFA module."
This seems to be a case of blindly updating the site modules, and now being blocked that on the Drupal 10 upgrade path, as the missed the release notes of the last release of this module ( https://www.drupal.org/project/ga_login/releases/8.x-1.0-alpha7 → ) that state:
If you used composer to update this module or drupal/tfa, you should now have tfa 8.x-1.0-alpha10 or newer. This module can now be removed by running the following composer commands:
composer require drupal/tfa:^1.0@alpha composer remove drupal/ga_login
The first command is only necessary if you previously only required the drupal/ga_login module. But it should not hurt to run both commands, even if you already required drupal/tfa.