All errors should have role alert for better accessibility when using client side validation

Working on it!!

The patch successfully applied for me the changes looks good to me because it adds accessibility to errors.

I've tested it on macOS with VoiceOver. I tried to save a webform without filling in the required fields. The screen reader announced the error message of the latest required field.

I think it's correct. But maybe it would be a good idea to have an a11y expert test the solution as well.

Came here very later after asking myself why the clientside_validation module, that already has that logic to add a role="alert" attribute built-in (if the inline_form_errors module is enabled) is behaving differently on Webforms.

Clientside Validation module:

• Here the library gets added dynamically: https://git.drupalcode.org/project/clientside_validation/-/blob/4.1.2/cl...
• And here a wrapper with the role="alert" attribute gets added: https://git.drupalcode.org/project/clientside_validation/-/blob/4.1.2/cl...

But then Webform module takes over:

• Library gets added dynamically: https://git.drupalcode.org/project/webform/-/blob/6.2.9/modules/webform_...
• With its own logic and no wrapper and no role="alert" attribute: https://git.drupalcode.org/project/webform/-/blob/6.2.9/modules/webform_...

And because of there there's now two different logics:

• Webform have no wrapper and no role attribute
• All other forms have the errors within another wrapper which has the proper role attribute

Two thoughts on this:

1. I think this should actually be fixed upstream: https://github.com/jquery-validation/jquery-validation/issues/2519
2. And up until then it would be nice to at least have kinda feature parity for webform_clientside_validation and clientside_validation_jquery (which even is a dependency of the webform_clientside_validation module), instead of overriding it. Means: webform_clientside_validation should also add that wrapper with that role attribute.

Looks good to me. Thanks