- Issue created by @quietone
- Status changed to Active
26 days ago 10:31am 4 July 2025 - First commit to issue fork.
- 🇮🇳India immaculatexavier
Hi @quietone,
Enabled Drupal.NamingConventions.ValidEnumCase sniff in core/phpcs.xml.dist. Verified the change by running PHPCS on a test enum file with intentional violations—errors were correctly reported.
Do you need any further actions?
- 🇳🇿New Zealand quietone
@immaculatexavier, the MR looks fine. The only thing is to remember to check that tests are passing before setting an issue to Needs Review. There was a failing test, which I presume, is why this was set back to Needs work. In this case the solution was simply to rerun the failing linting test. Then, since that passed the next step was to start the tests. All that is from the GitLab UI.
I reran test failing tests and tests are passing now.
- 🇺🇸United States xjm
Thanks @immaculatexavier. #8 is definitely a good way to evaluate this issue.
Previously, we would have added this to the release notes for the minor since it's enabling a new PHPCS rule, but we stopped doing that except in extreme cases. In the case of this rule, it is a very small addition (as can be seen from the fact that core already passes).
Committed to 11.x only as an addition to the core ruleset. Thanks everyone!