OG reference field widget update: MR #570 did not properly merge, leaving og_complex in place

Created on 25 February 2025, about 1 month ago

Problem/Motivation

The OG project had a merge request (#570) that aimed to replace the og_complex widget with a standard entity_reference single input widget. The MR appears to be merged, but the changes were not correctly applied to the codebase.

Steps to reproduce

  1. Check the current implementation of the OG reference field widget.
  2. Compare it with the intended changes from MR #570.
  3. Observe that the expected replacement of og_complex with entity_reference has not taken effect.

Proposed resolution

Verify why the changes from MR #570 did not properly merge and ensure the intended modifications are applied.

Remaining tasks

  • Investigate the commit history to determine why the merge did not take effect.
  • Reintroduce the intended changes if necessary.
  • Review and test to confirm the entity_reference widget is now used instead of og_complex.

User interface changes

The OG reference field should now use a standard entity reference input instead of the og_complex widget.

📌 Task
Status

Active

Version

1.0

Component

og.module

Created by

🇨🇦Canada joelpittet Vancouver

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @joelpittet
  • 🇨🇦Canada joelpittet Vancouver

    I did my best to merge the diff from https://github.com/Gizra/og/pull/570, there are a bunch of todo's we should fix before merging this, and we should add a way to transition anybody who is currently using og_complex

  • I was testing this out and found a bug when validating the Groups audience field.
    Steps to reproduce:
    1. Create a group
    2. Pick another content type, and associate it with the group in the first step. I picked the Article node. And go to Manage form display for Article and change the widget from Select list to Autocomplete (Select list seems buggy and will not show anything)
    3. Create a new test user and add it to the group.
    4. As an admin, go to admin>configuration>organic groups>og roles> and edit the roles for the group you created. Under Group content check Article: Edit any content (since I selected Article in step 2) Side note: there might also be a bug here because if you just gave the test user permission to edit any Article, it seems that they are not able to edit the group content, which is an Article, without doing this step.
    5. Also as an admin, give the test user the permission Article: Edit any content
    6. Now log in as the test user and create a new Article and associate it with the group.
    7. As the test user, edit the content and then try to save the node. You will see an error that looks like this:
    This entity (node: 1) cannot be referenced.
    and it is a validation error for the Groups audience field.
    Expected result:
    The test user should have been able to save that group content and not see that error.

  • Pipeline finished with Failed
    about 1 month ago
    Total: 508s
    #435255
  • Pipeline finished with Failed
    about 1 month ago
    Total: 623s
    #436268
  • Pipeline finished with Failed
    about 1 month ago
    Total: 592s
    #440127
  • Pipeline finished with Failed
    about 1 month ago
    Total: 543s
    #441442
  • Pipeline finished with Failed
    29 days ago
    Total: 943s
    #442373
  • 🇷🇴Romania claudiu.cristea Arad 🇷🇴

    Let's target 2.x and NOT backport, so we don't break any site which uses 8.x-1.x. Please change the base branch of MR, I have no permissions

  • Pipeline finished with Failed
    20 days ago
    Total: 829s
    #449276
  • Pipeline finished with Failed
    18 days ago
    Total: 985s
    #450532
  • Pipeline finished with Failed
    18 days ago
    Total: 6904s
    #450546
  • Pipeline finished with Failed
    18 days ago
    Total: 839s
    #450746
  • Pipeline finished with Failed
    16 days ago
    Total: 1525s
    #452653
  • Pipeline finished with Failed
    16 days ago
    Total: 515s
    #452805
  • Pipeline finished with Failed
    16 days ago
    Total: 678s
    #452808
  • Pipeline finished with Failed
    11 days ago
    Total: 640s
    #456645
  • Pipeline finished with Failed
    9 days ago
    Total: 689s
    #458356
  • Pipeline finished with Failed
    7 days ago
    Total: 589s
    #460013
  • Pipeline finished with Failed
    4 days ago
    Total: 798s
    #462021
  • Pipeline finished with Failed
    4 days ago
    Total: 663s
    #462052
  • Pipeline finished with Failed
    3 days ago
    Total: 709s
    #462739
  • Pipeline finished with Failed
    3 days ago
    Total: 442s
    #462814
  • Pipeline finished with Failed
    3 days ago
    Total: 619s
    #462833
  • 🇨🇦Canada joelpittet Vancouver

    joelpittet changed the visibility of the branch 8.x-1.x to hidden.

  • Pipeline finished with Failed
    2 days ago
    Total: 683s
    #463720
  • Pipeline finished with Failed
    2 days ago
    Total: 732s
    #463861
  • Pipeline finished with Failed
    1 day ago
    Total: 496s
    #464757
  • Pipeline finished with Failed
    1 day ago
    Total: 679s
    #464887
  • Pipeline finished with Failed
    about 7 hours ago
    #465934
Production build 0.71.5 2024