Assets paths in CSS no longer rewritten when aggregation is enabled

benabaird → changed the visibility of the branch 11.x to hidden.

benabaird → changed the visibility of the branch 3535330-assets-paths-in to hidden.

benabaird → closed merge request !12686

First time doing this, I guess I opened a request somehow on 11.x. Sorry for the noise.

I've changed the check to look at the asset type rather than whether it's minified. https://git.drupalcode.org/project/drupal/-/merge_requests/12687 has green tests, so marking this as needs review.

Ah just ran into an issue on this, will need to check the solution more.

In Drupal core changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies → . Thanks

Yep changes should be on 11.x and backported.

Just ran into this when all my custom fonts disappeared.

I think this MR also needs a _new_ test to confirm that relative paths are being replaced as expected.

Hello, thanks for creating this issue.
I did hit this as explained in #3414173-37: Add support for minified external CSS libraries → (comments 37-39).
But I also hit another issue which relates to 🐛 Only file JavaScript assets with preprocessing enabled can be optimized. Active
Both are closely related so I opened 🐛 "Only file JavaScript/CSS assets can be optimized" errors in logs Active and proposed a slightly different approach.
Any feedback is welcome :) Thanks

joelpittet → changed the visibility of the branch 11.x to active.

joelpittet → changed the visibility of the branch 11.x to hidden.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

@dalin I tried my hand to add some more tests for a few of these cases but I didn't want to step on @benabaird's toes so I put it on a new branch MR 12687 with slightly different take on how to solve this and some more comments.

@benabaird I hope this works for you?

Confirming this major issue if aggregation is enabled.

@anybody if by chance you can review and test the solution fixes the problem that would help move it along. It's got tests to go with the direction I am hoping to take this.

Thanks, I'll ask @thomas.frobieter to give it a try in the affected project!

I can no longer see any problems, it works perfectly again!

Committed/pushed to 11.x and cherry-picked to 11.2.x, thanks!