- Issue created by @claudiu.cristea
- 🇺🇸United States quicksketch
Thanks @claudiucristea for your work on this! Rather than commit to the 8.x-1.x branch, maybe this should take on a new branch as part of dropping Drupal 9 (and older 10) support? It would also be an opportunity to drop the "8.x-" prefix, and make this a safer, easier change for users upgrading, since any issues could be worked out in the new branch rather than impacting the (relatively stable) 8.x-1.x branch.
- 🇮🇱Israel amitaibu Israel
@quicksketch! It's good to have you around. Are you using OG 8.x with Backdrop?
> It would also be an opportunity to drop the "8.x-" prefix
👍
- 🇨🇦Canada joelpittet Vancouver
@claudiucristea I am +1 to make a 2.x release too, does that work for you too?
RE
Read-only class properties
I backed out of them in this issue because of a serialization problem 🐛 Error: Cannot initialize readonly property Drupal\og\Plugin\Field\FieldWidget\OgComplex::$membershipManager Active
- 🇷🇴Romania claudiu.cristea Arad 🇷🇴
OK, moved to new 2.x. I think this branch should be set as default branch and main development to be done against 2.x. Only some issues should be back ported to 8.x-1.x. I don't have enough permissions to change the default branch. @amitaibu?
- 🇮🇱Israel amitaibu Israel
@claudiu.cristea. Thanks. You already have `Administer releases`. However, when I try to set 2.x as recommended, it appears disabled.
-
joelpittet →
committed d8ded3ae on 2.x authored by
claudiu.cristea →
Issue #3503767 by claudiu.cristea, joelpittet: Drupal 10.3 is minimum...
-
joelpittet →
committed d8ded3ae on 2.x authored by
claudiu.cristea →
- 🇨🇦Canada joelpittet Vancouver
I cherry-picked the version into the 2.x branch to move the needle a bit, I want to get some constraints using PHP attributes.
-
joelpittet →
committed eef8fc09 on 2.x authored by
claudiu.cristea →
Issue #3503767 by claudiu.cristea: DDEV config update for Drupal 10.3...
-
joelpittet →
committed eef8fc09 on 2.x authored by
claudiu.cristea →
- 🇷🇴Romania claudiu.cristea Arad 🇷🇴
The MR affects ~200 files. That's already huge and hard to review. I'm proposing that we split scope to 📌 Modernize code (part 2) Active . See IS to learn what was covered din the current MR
- 🇨🇦Canada joelpittet Vancouver
Reviewed about half of the files touched here, caught a couple of things and they were addressed. This is good enough to be committed to the dev branch as all the big things are addressed and lots of huge improvements. Anything missed can be caught in production 🚀 🫣
Thanks @claudiu.cristea for taking this on!
-
claudiu.cristea →
committed 404bb45b on 2.x
Issue #3503767 by claudiu.cristea, joelpittet: Support Drupal >=10.3....
-
claudiu.cristea →
committed 404bb45b on 2.x
- 🇷🇴Romania claudiu.cristea Arad 🇷🇴
Thank you for review, @joelpittet. The work will continue in 📌 Modernize code (part 2) Active
Automatically closed - issue fixed for 2 weeks with no activity.