Israel
Account created on 23 April 2006, over 18 years ago
#

Recent comments

🇮🇱Israel amitaibu Israel

Thanks,

> Do we still need to support Drupal 9 (from info.yml)?

Yes, we should. Like we have it still on OG

🇮🇱Israel amitaibu Israel

Thanks, guys. Moving to another module is a great idea.

> Note that Group module is doing something similar by relying on flexible_permissions module (which is now added in core as Access Policy API)

It may not fit into OG access, which has a field to determine if it's private or public (and write a record into the node grants system). But it can likely be used in OG core, where we do some heavy lifting to decide if a user has access. In fact, some years ago, as we prepared for this blog post @kristiaanvandeneynde has mentioned he had plans to get this functionality out of Group. We also said it would be nice for both Group and OG to rely on it. Ideally, reducing both of the module's own code.

🇮🇱Israel amitaibu Israel

I've also granted your maintainer rights, so you could create releases

🇮🇱Israel amitaibu Israel

Thanks, can you please create an MR? It's easier to review :) And you can always use the `.diff` from the MR in your composer.json

🇮🇱Israel amitaibu Israel

@claudiu.cristea thanks!

🇮🇱Israel amitaibu Israel

Thanks folks. Would anyone be willing to add a test to the MR?

🇮🇱Israel amitaibu Israel

Thank you 🙏

Done, I've added a note on the README on GH, and archived the repo (see image)

🇮🇱Israel amitaibu Israel

Wow, happy to see people still using the module. Open source ❤️

🇮🇱Israel amitaibu Israel

Thanks folks, commited. I'll create a new branch next week

🇮🇱Israel amitaibu Israel

Alright, fair enough. Thank you for doing it!

🇮🇱Israel amitaibu Israel

@klausi Oye. I didn't know one could not re-enable support. Maybe if we contacted Admin there, it would be possible? I think that having to fork isn't get for the community.

🇮🇱Israel amitaibu Israel

@bluegeek9 you now have the maintainer super powers ✌️. Thank you

🇮🇱Israel amitaibu Israel

Thanks, please create this as a PR on Gitlab.

Production build 0.71.5 2024