[regression] MembershipManager::getMembership since 1.0.0-alpha11

I propose to extend the scope slightly and add some safety checks in the sevice methods to return early in case the $group entity is new/has no ID yet.

Thank you; I no longer see the 'Deprecated function: addcslashes(): Passing null to parameter' error.

Thanks folks. Can we add a test to confirm this behavior?

Sure, I added a very basic test in GroupMembershipManagerTest.
It fails as expected if we revert the fix (see test-only-changes job).
Hope that's good enough.

For some reason, I don't see it was merged on the issue - but it was https://git.drupalcode.org/project/og/-/commit/585cd45aff56012ac033de471...

Thanks 🙏

Thanks @amitaibu, should we also backport this to 1.x? since the issue is there also.

@herved I have committed it to 1.x too. Sorry I rushed and should have created a separate MR and just cherry-picked the 2 commits, a bit messy.

Automatically closed - issue fixed for 2 weeks with no activity.