- Issue created by @joelpittet
- 🇨🇦Canada joelpittet Vancouver
Related to 📌 Support Drupal >=10.3. Modernize the code Active
- 🇨🇦Canada joelpittet Vancouver
Also related to 📌 Resolve PHPStan Errors and PHPUnit 10 Compatibility Issues in Drupal 11+ Active
I am going to dial up the PHPStan level slowly here (scope creep I know) but I think it's important to catch more real issues.
I will address these issues too.
------ ------------------------------------------------------------ Line og/og.module ------ ------------------------------------------------------------ 53 Variable $owner in empty() always exists and is not falsy. ------ ------------------------------------------------------------ ------ ------------------------------------------------------------------------------- Line og/src/Plugin/Validation/Constraint/UniqueOgMembershipConstraintValidator.php ------ ------------------------------------------------------------------------------- 43 Variable $value in isset() always exists and is not nullable. ------ ------------------------------------------------------------------------------- ------ --------------------------------------------------------------------------------------- Line og/src/Plugin/Validation/Constraint/ValidOgMembershipReferenceConstraintValidator.php ------ --------------------------------------------------------------------------------------- 33 Variable $value in isset() always exists and is not nullable. ------ --------------------------------------------------------------------------------------- ------ ------------------------------------------------------------------------ Line og/src/Plugin/Validation/Constraint/ValidOgRoleConstraintValidator.php ------ ------------------------------------------------------------------------ 20 Variable $value in isset() always exists and is not nullable. ------ ------------------------------------------------------------------------ - 🇨🇦Canada joelpittet Vancouver
I don't know why I ignored the phpstan.neon in the first place...
- 🇨🇦Canada joelpittet Vancouver
Way too many issues on level 2 (mostly test related) that I will save that fun for a follow-up.
- Merge request !49Ignore PHPStan PHP attribute/annotation false positive, unignore phpstan.neon... → (Merged) created by joelpittet
-
joelpittet →
committed 403ae83e on 2.x
Issue #3541671 by joelpittet: PHPStan fails on 'previous major' (Drupal...
-
joelpittet →
committed 403ae83e on 2.x
Automatically closed - issue fixed for 2 weeks with no activity.