- Issue created by @apkwilson
- 🇺🇸United States apkwilson
apkwilson → changed the visibility of the branch 3452532-duplicate-rows-for to hidden.
- 🇺🇸United States apkwilson
apkwilson → changed the visibility of the branch 3452532-duplicate-rows-for to active.
- 🇺🇸United States apkwilson
apkwilson → changed the visibility of the branch 3452532-duplicate-rows-for to hidden.
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
about 1 year ago Waiting for branch to pass - Status changed to RTBC
about 1 month ago 12:43am 21 June 2025 - 🇺🇸United States daniel korte Brooklyn, NY
Works for me and is simple enough. Thanks!
- First commit to issue fork.
- 🇨🇦Canada joelpittet Vancouver
Probably overkill but I want to get more tests in this module so getting the ball rolling here. Thanks for this, fix btw @apkwilson, it fixes a problem for me with date_recur I was seeing as well, so I will commit it really soon!
- 🇨🇦Canada joelpittet Vancouver
joelpittet → changed the visibility of the branch 8.x-1.x to hidden.
- 🇨🇦Canada joelpittet Vancouver
Moved the duplicate-check logic into a new instance-based
isEntityAlreadyRendered($id)
method. This change was motivated by two goals:- Making the code much easier to test.
- Simplifying the render() method by removing internal static logic.
Test highlights
- First call with an ID → false
- Second call with the same ID → true
- New ID resets correctly → false, then true
- Calling the first ID again later → true, confirming we now track all previously rendered IDs—not just the last one, which was the regression we fixed.
Real‑world verification
I manually reverted to the old static-based logic insideisEntityAlreadyRendered()
and confirmed the last assertion failed. I also tested with a realdate_recur
scenario—this solution behaves identically to the static version but is hopefully easier to maintain and test.I manually reverted to the old static-based logic inside isEntityAlreadyRendered() and confirmed the last assertion failed. I also tested with a real date_recur scenario—this solution behaves identically to the static version but is cleaner and easier to maintain and test.
-
joelpittet →
committed c3ef8300 on 8.x-1.x authored by
apkwilson →
Issue #3452532 by joelpittet, apkwilson, daniel korte: Duplicate rows...
-
joelpittet →
committed c3ef8300 on 8.x-1.x authored by
apkwilson →
- 🇨🇦Canada joelpittet Vancouver
I've committed this to the dev branch for hopefully a quick release, thanks again @apkwilson and @daniel korte for bring this issue up and finding a solution!