- Issue created by @rkoller
- Merge request !8Issue #3531377: fix: Replace headings checkbox with radio button for heading scope selection. → (Open) created by Unnamed author
- 🇩🇪Germany rkoller Nürnberg, Germany
Thank you for working on the issue! I've tested MR8, two observations:
1) It looks like the set radio buttons has no effect at all. no matter if i select main-only or full-dom, each time all the headings of the entire dom are displayed in skipto
2) the label for the first radio button (
Only within the <main> element) is broken, main is being hidden and you only seeOnly within the elementprobably no need to use angle brackets. will have to think about the wording
- 🇩🇪Germany rkoller Nürnberg, Germany
Fixed the problem. It couldnt have worked to simply adding the value of the radio button to the $config_export array. instead you have to check if the radio button has selected the option for within the main element and then append main-only to the headings object and the default radio button setting was also missing from the settings.yaml in the install folder. now everything is functional. but i'll postpone the issue on the micro copy issue [#3516073 . that one changes that much in the code that also the changes within this issue become tricky to rebase i suppose. and also the radio button microcopy needs some more refinement. but the microcopy issue should be solved first.