- Issue created by @lostcarpark
- 🇮🇳India nidhi27
Hii @kul.pratap,
For path field its not showing the forward slash.
But for redirect_path field it is still showing the forward slash.
As per point 3,
In src/From/VerifyEmailAddEditForm, remove the '#field_prefix' => '/' from path and redirect_path. Add a #description stating the path should be a valid path within the site.Needed to change in redirect path as well.
Kindly refer the comment above. Thanks!
- 🇮🇪Ireland lostcarpark
This change is almost ready, but just needs finishing off.
All the necessary changes are in
VerifyEmailAddEditForm
:- In the
path
field move the "description" under "title", and "leave empty to use the front page" to "use for front page." - In
redirect_path
remove the "#field_prefix". - Also in
redirect_path
, add a "description" property with text of "The internal path the user will be redirected, including leading slash, or to redirect to front page of site."
- In the
- 🇮🇪Ireland lostcarpark
Please just update the number in the update hook, and we will be good to merge.
Thanks for your work!
- 🇮🇪Ireland lostcarpark
I didn't realise the update hook ID must be above 8000. I'm suggesting we start from 10001 since we have no connection to Drupal 8.
Also, we should add a type hint for the entity so that properties and methods can be validated.
Hopefully that will be the very last thing before we merge.
- 🇮🇪Ireland lostcarpark
I have tested manually, including the update hook.
Tests are passing, and code looks good.
Moving to RTBC.
-
lostcarpark →
committed 5e53ba01 on 1.0.x authored by
kul.pratap →
Issue #3518627: Change path redirect_path.
-
lostcarpark →
committed 5e53ba01 on 1.0.x authored by
kul.pratap →