- Issue created by @Anybody
- Assigned to nidhi27
- Merge request !13Added condition to hide Disable front page redirects for the administrator role checkbox. → (Open) created by nidhi27
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 12:29pm 5 April 2024 - 🇮🇳India nidhi27
I have created #MR13 to hide the checkbox based on the condition.
Kindly review it and let me know if any changes are needed. - Status changed to Needs work
about 1 year ago 1:33pm 5 April 2024 - 🇩🇪Germany Anybody Porta Westfalica
Thanks @nidhi27 I left a comment. Please fix it and test yourself.
- 🇮🇳India nidhi27
Hi @Anybody,
Please check my comment and provide your input.
- 🇩🇪Germany Anybody Porta Westfalica
Could you eventually add test coverage for these options? (not the states api part)?
Then we'd be safe it works as expected now and in the future!
TL;DR: If hidden, the checkbox should never be "TRUE" after save.
- 🇮🇳India nidhi27
Hi @Anybody,
I think It would be great if we add all the test cases together in https://www.drupal.org/project/front/issues/3438834 📌 Write tests Active . Let me know what do you suggest.
- Status changed to Needs review
about 1 year ago 2:51pm 5 April 2024 - Assigned to Grevil
- 🇩🇪Germany Anybody Porta Westfalica
Great! Ready for sign-off by codemaster @Grevil! :)
- Assigned to nidhi27
- 🇮🇳India nidhi27
Hii,
I have added the test case for this functionality. Let me know if any changes are needed.
Thanks!