- Issue created by @lostcarpark
- 🇮🇪Ireland lostcarpark
A couple of small points. It's helpful to use a type hint comment so that IDEs know the class to use and can offer code completion and warn about missing functions.
Also, where a specific getter is available, we should use it rather than the generic
get()
.Fix those and we should be ready to merge.
- 🇮🇪Ireland lostcarpark
I've confirmed the needed changes have been made.
I've tested the update hook in a local environment, installed with the 1.0.0-alpha4 release, than checking out this branch and running the update script with Drush.
I have verified that the token was added to the email body as expected.
Moving back to RTBC, ready for merge. -
lostcarpark →
committed 36e6f9fd on 1.1.x authored by
lavanyatalwar →
Resolve #3528713 "Add update hook"
-
lostcarpark →
committed 36e6f9fd on 1.1.x authored by
lavanyatalwar →
- 🇮🇪Ireland lostcarpark
Merged successfully. Thank you @lavanyatalwar and @nidhi27 for your work on this.
Moving to Fixed. Automatically closed - issue fixed for 2 weeks with no activity.