[1.0.x] Cookie Compliance

Created on 28 June 2024, 7 months ago
Updated 29 June 2024, 7 months ago

Integrate cookie compliance by humanity.co on drupal website. This is a simple module to add the relevant integration codes for cookie compliance.

https://www.drupal.org/project/cookie_compliance

📌 Task
Status

Closed: won't fix

Component

module

Created by

🇸🇬Singapore anish.a Singapore

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @anish.a
  • 🇮🇹Italy apaderno Brescia, 🇮🇹

    Thank you for applying!

    Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

    The important notes are the following.

    • If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
    • For the time this application is open, only your commits are allowed.
    • The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status will not be changed by this application; once this application is closed, you will be able to change the project status from Not covered to Opt into security advisory coverage. This is possible only 14 days after the project is created.
      Keep in mind that once the project is opted into security advisory coverage, only Security Team members may change coverage.
    • Only the person who created the application will get the permission to opt projects into security advisory coverage. No other person will get the same permission from the same application; that applies also to co-maintainers/maintainers of the project used for the application.
    • We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

    To the reviewers

    Please read How to review security advisory coverage applications , Application workflow , What to cover in an application review , and Tools to use for reviews .

    The important notes are the following.

    • It is preferable to wait for a project moderator before posting the first comment on newly created applications. Project moderators will do some preliminary checks that are necessary before any change on the project files is suggested.
    • Reviewers should show the output of a CLI tool only once per application.
    • It may be best to have the applicant fix things before further review.

    For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues .

  • Status changed to Needs work 7 months ago
  • 🇮🇹Italy apaderno Brescia, 🇮🇹

    Usually, after reviewing a project, we allow the developer to opt projects into security advisory coverage. This project is too small for us and it doesn't contain enough PHP code to really assess your skills as developer.

    Have you created any other project on drupal.org (module, theme, distribution) we could instead review? The project needs to have most of the commits (preferable all the commits) done by you.

  • 🇸🇬Singapore anish.a Singapore

    Sorry, I don't have any other modules/themes listed in drupal.org. Is there any approximate number of lines in the code to qualify for a review?

  • 🇺🇸United States bradjones1 Digital Nomad Life

    I'd add that the README seems to indicate this was scaffolded from a template or code-generation library. Which is fine, but it also goes to the point already made, that there's not much here to go on that helps demonstrate a minimum level of maintainer competence.

    The security opt-in process isn't perfect, and I've been frustrated with it as well in the past, but I would say that you need to avoid things like this that don't help to instill confidence during review.

    https://git.drupalcode.org/project/cookie_compliance/-/blob/1.0.x/README...

  • Status changed to Closed: won't fix 7 months ago
  • 🇸🇬Singapore anish.a Singapore

    I apologize for the same. I had to use drush generate to generate the module and forms. This was developed for the usage in multiple websites for a client and we decided to publish it so that others can benefit.

    I understand that the module is too small to opt into security coverage. So, I am closing the task.

Production build 0.71.5 2024