Standardize location of test modules

Looks like an excellent cleanup!

Committed to 11.x and backported to 10.3.x

Thanks

larowlan → closed merge request !7405

Discussed this with @alexpott
At the time of committing I did consider this might be disruptive, but alexpott felt it definitely was so on that basis rolling it back

Alex pointed out that at some point we will get to tests/* so the fact these aren't in modules won't matter so much

I don't think we need to do this issue. I think we can just wait to catch the outliers when you change the include to be <include-pattern>*/tests/*</include-pattern>

I think we can go ahead with 📌 Add declare(strict_types=1) to all test modules Postponed and just rename it to something to do with MODULE/tests/modules so we don't reject because it is not ALL test modules.

I think the correct status for this is closed won't fix but going to move to needs review to build consensus

Sounds fine to me, I think we can target */tests/modules/* and */tests/*_test/* and catch the outliers later.

Thanks

I'd like to reopen this since I had the same question and have had the same grepping issue in the past trying to see what test modules are doing.

Link to discussion in slack https://drupal.slack.com/archives/C079NQPQUEN/p1752356974306669 (Note if you copy this link, open slack and search for the link it will bring you to the discussion rather than linking to the browser).

It was reverted because it was thought to be disruptive, but I would like to reopen that discussion.
First these are test modules not tests, and most test modules do not change very often.

Most of the modules have not been changed in months, and the changes were by people in agreement that they should be moved:
@mstrelan, @acbramely, and myself.

Here is a list of the modules with test modules in non standard locations and the most recent change.

• config 1 was edited two weeks ago by acbramley most of the rest are 4 months to 1 year
• dynamic_page_cache 10 months ago
• file most 4 to 10 months ago two edited 3 days ago
• filter 1 and 10 months ago
• language 4 months to 1 year ago
• menu_link_content 5 months to 1 year ago
• navigation 3 days ago
• node 7 months ago
• options 5 months to 1 year
• serialization 4 months ago

Notable exceptions
These all seem related to code sniffing updates.
config
file
navigation

All in all, almost all changes to these are bulk updates like conversions or sniffing that would benefit from a standard location.
A one time disruption makes sense.
The other users I see are quietone and borisson_ I could ping them as well.

Another bit of evidence is the majority of these modules the last change was the revert commit in this very issue.

This is postponed on #3067979: Exclude test files from release packages →

I wondered what happened to this issue. This change would make it easier to complete some, but not all, of the core coding standards issues. I also think that core should be consistent in structure. We all know how that can benefit searching and organizing work.

Restoring meta data.

Why is this postponed on #3067979: Exclude test files from release packages → ?