Standardize location of test modules

Looks like an excellent cleanup!

Committed to 11.x and backported to 10.3.x

Thanks

larowlan → closed merge request !7405

Discussed this with @alexpott
At the time of committing I did consider this might be disruptive, but alexpott felt it definitely was so on that basis rolling it back

Alex pointed out that at some point we will get to tests/* so the fact these aren't in modules won't matter so much

I don't think we need to do this issue. I think we can just wait to catch the outliers when you change the include to be <include-pattern>*/tests/*</include-pattern>

I think we can go ahead with 📌 Add declare(strict_types=1) to all test modules Postponed and just rename it to something to do with MODULE/tests/modules so we don't reject because it is not ALL test modules.

I think the correct status for this is closed won't fix but going to move to needs review to build consensus

Sounds fine to me, I think we can target */tests/modules/* and */tests/*_test/* and catch the outliers later.

Thanks