Add declare(strict_types=1) to all test modules

Also postponed on 📌 Standardize location of test modules Needs review

📌 Standardize location of test modules Needs review is likely a won't fix, so we can continue with just the modules that match the patterns in the issue summary.

We can just about get away with combining this with 📌 Enforce strict types in tests Fixed . I've updated the include/exclude paths as below:

<include-pattern>*/tests/*</include-pattern>
<exclude-pattern>*/fixture/*</exclude-pattern>
<exclude-pattern>*/fixtures/*</exclude-pattern>

I noticed the following additional files that I guess are technically out of scope for this issue, there may be a few others. Maybe we manually exclude them and address them in 📌 Enforce strict types in tests Fixed ?

core/modules/comment/src/Tests/CommentTestTrait.php
core/modules/contact/tests/drupal-7.contact.database.php
core/modules/system/tests/http.php
core/modules/system/tests/https.php
core/tests/bootstrap.php

Let's see what the testbot thinks anyway, there could be new errors introduced recently.

Well #9 was a bit ambitious. There are a few other traits and such that are problematic. Reverted to original scope. Looks like there are about 3 more tests to fix.

Large MR! I skimmed a few dozen files and does appear to just be added strict_type.

The deletions appear to be replacing few instances of space around the = sign.

Question for committers but seem it also added

/**
* @file
*/

To some test module files. Do we care if there is no description? Should a novice issue be opened to address those?

Thanks for pointing out those @file things. Phpcbf seems to get confused adding strict types alongside @file blocks. I'll fix those up manually.

Fixed all the @file blocks that were added when we already had them and rebased off HEAD.

Test failure appeared random

Latest updates still appear fine.

Unfortunately, this needs to be rebased.

I also noticed is that this is using the string declare(strict_types=1); but, according to coding standards,there should be a space on each side of the "=" side. But later in the standard, the example for declaring string types uses the string as shown before. That is a problem for coding standards to sort out.

I went through all the changes and did not find any problems with the changes.

Where does it say to use a space? There was an issue and standards committee process for this and we settled on no space.

#3303206: Define a standard for adding declare(strict_types=1) →

Rebase seems good.

I actually remember in a few modules having the space and then randomly it went no space so had to fix a bunch myself.

Sorry, my fault the standard → for this does say that the space is omitted.

The declare statement is written without spaces around the equals sign.

This is still adding empty @file blocks which looks like a mistake? If it's not, the issue summary could use an update.

Sorry about missing that. This should have corrected all the @file problems.

Thanks looks good now. Getting this in while it still applies cleanly.

Committed/pushed to 11.x, thanks!

catch → closed merge request !5309

Automatically closed - issue fixed for 2 weeks with no activity.