- Issue created by @andrewmacpherson
- Merge request !12811Issue #3527142 by andypost, catch, longwave, xjm: Update Composer and... β (Closed) created by andrewmacpherson
- π¬π§United Kingdom andrewmacpherson
I have no idea what went wrong in creating that merge request. I tried doing it quickly with editing the MAINTAINERS.txt.
- π¬π§United Kingdom andrewmacpherson
Right. It's the one called: 3537409-remove-accessibility-topic-maintainer-andrewmacpherson
- Merge request !12812Issue #3527142 by andypost, catch, longwave, xjm: Update Composer and... β (Closed) created by andrewmacpherson
- π¬π§United Kingdom andrewmacpherson
Strewth. It's gone wrong agin.
It all looked fine, until I pressed the GitLab button to create the merge request. Now it's picking up changes for a different issue. I didn't edit any of those files.
- π¬π§United Kingdom andrewmacpherson
I think these misadventures are because I'm tried to fork from the 11.2.x branch, but the GitLab was picking 11.x to create the merge requests. (Maybe? The "commits ahead/behind" message gave me that clue, and
git log 11.x..11.2.x --oneline | wc
tallies with it.)Sod this for a box of frogs. Just do it the old fashioned way wi' a patch file.
- π¬π§United Kingdom andrewmacpherson
andrewmacpherson β changed the visibility of the branch 3537409-remove-accessibility-topic-maintainer-andrewmacpherson to hidden.
- π¬π§United Kingdom andrewmacpherson
andrewmacpherson β changed the visibility of the branch 3537409-remove-accessibility-maintainer to hidden.
The Needs Review Queue Bot β tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- π¬π§United Kingdom andrewmacpherson
The bot is bothered by the merge requests, not the patch in #8
- First commit to issue fork.
- πΊπΈUnited States nicxvan
Thank you for helping out with one of my first core issues! https://www.drupal.org/project/drupal/issues/3333401 π Pager h4 causes accessibility flag on many pages Fixed
I took care of the mr for you, I think you were right it was because the branch was 11.2, it needed to be 11.x
- π¬π§United Kingdom andrewmacpherson
Thanks nicxvan, that'll do nicely. I was used to filing against a major.minor branch in the past; I gather it's just against the current major version now.
- π¬π§United Kingdom andrewmacpherson
Re. #19: Ah yes, the skipped heading levels for the pager. I remember the issue very well. Thanks for seeing it through; the heading level option is a rather good outcome.
- πΊπΈUnited States benjifisher Boston area
Thank you for all the work you have done for Drupal over the years! Drupal has gained a lot from your expertise. Personally, I picked up a few pointers about accessibility (a11y) but I am certainly not an expert.
- πΊπΈUnited States xjm
@andrewmacpherson, thank you so much for all your dedicated work on core's accessibility! You made a huge difference for core in helping us to think critically about accessibility for so many major core features. I still think of your input whenever I remind myself or others that we need to put accessibility first.
Also, thank you for teaching me a marvelous new cuss:
Sod this for a box of frogs
Committed to 11.x, 11.2.x, 10.6.x, and 10.5.x. I will also update the core node, the Google group, and the maintainer channel since this was @andrewmacpherson's single maintainer role.