- Issue created by @quietone
- π§πͺBelgium borisson_ Mechelen, π§πͺ
Found some places where we could align better, I personally really dislike things that end up looking like this:
]));
- π³πΏNew Zealand quietone
Simple conflict in phpcs.xml.dist, restoring RTBC.
- π³πΏNew Zealand quietone
A rebase with simple conflict in phpcs.xml.dist, so restoring RTBC.
The Needs Review Queue Bot β tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- π³πΏNew Zealand quietone
Rebased, simple conflict in \Drupal\Tests\jsonapi\Functional\NodeTest so restoring RTBC.
The Needs Review Queue Bot β tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
The Needs Review Queue Bot β tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- Status changed to Needs work
about 1 month ago 8:17pm 24 May 2025 The Needs Review Queue Bot β tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- π¬π§United Kingdom longwave UK
As per the kernel test ones a lot of these look odd to me now, matching braces should always have the same indentation I think?
- π¬π§United Kingdom longwave UK
Fixed up everything to make more sense to me at least, hopefully it is clear to everyone else as well.