- 🇺🇸United States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.
So the proposed use case sounds like it would be better to have an alter hook to edit this variable?
Tagging for subsystem maintainer review
Either way it will require tests too.
- 🇮🇳India nikhil_110
Re-roll Patch #9 and interdiff file not generate...
Patch #9 not applied
- The following problem appears...
( error: patch failed: core/modules/content_translation/src/ContentTranslationHandler.php:563
error: core/modules/content_translation/src/ContentTranslationHandler.php: patch does not apply ) - 🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
Re-roll Patch #13 due to Failed Patch.
- Status changed to Needs review
over 2 years ago 2:16pm 16 February 2023 - Status changed to Needs work
about 2 years ago 2:28pm 17 February 2023 - 🇬🇧United Kingdom catch
+++ b/core/modules/content_translation/src/ContentTranslationHandler.php @@ -564,11 +565,9 @@ public function entityFormAlter(array &$form, FormStateInterface $form_state, En - // multilingual value. - if (!isset($ignored_types)) { + if (empty($ignored_types)) { $ignored_types = array_flip(['actions', 'value', 'hidden', 'vertical_tabs', 'token', 'details', 'link']); }
The default array of types can be in the default argument to Settings::get().
Having said that, putting this in settings doesn't allow modules to alter it. I think it would be better as a container parameter or similar.
- 🇩🇪Germany tstoeckler Essen, Germany
There is #3109887: Find a more reliable way to determine if a form element concerns a multilingual value. → also which tries to solve by making this an element property. This can be altered via
hook_element_info_alter()
which I think would be preferable to the setting and in my opinion is better suited for such a "niche" feature than a container parameter. Technically this issue precedes that one, so not sure if that one should be marked as a duplicate or if we should just continue there instead. Either way needs to be converted to a merge request and needs some tests.