Confirmation cancel links are incorrect if installed in a subdirectory

-    $data[] = ['baz'];
-    $data[] = ['/baz'];
+    $data[] = ['baz', ''];
+    $data[] = ['/baz', ''];
+    $data[] = ['baz', '/base/path'];
+    $data[] = ['/base/path/baz', '/base/path'];

Think we should still be able to cover when nothing is based in 2nd.

Here is a 10.1.x patch for composer.json. Please do NOT give me commit credit for this patch.

Thank you to everyone above, I just spent 90 minutes trying to figure out this issue and then determined that it had to be a core bug. And sure enough, you all have done my work !
Thank you!

Elevating to framework manager

There is outstanding feedback on the MR, it needs work, not a framework manager review.

Nikolay Shapovalov → made their first commit to this issue’s fork.

I added changes suggested by Mohammed Nassar to the MR 4160.

I don't understand @smustgrave's suggestion:

Think we should still be able to cover when nothing is based in 2nd.

Can someone please explain?

Is it possible to hide patch files, and branches that not in use?

I think this is ready for review.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

MR 4160 is mergeable, update status back to needs review.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

I have tested MR https://git.drupalcode.org/project/drupal/-/merge_requests/4160
Looks good, can be moved to RTBC.

alexpott → changed the visibility of the branch 2582295-confirmation-cancel-links-10.1.x to hidden.

alexpott → changed the visibility of the branch 2582295-confirmation-cancel-links-10.0.x to hidden.

alexpott → changed the visibility of the branch 2582295-confirmation-cancel-links-11.x to hidden.

alexpott → changed the visibility of the branch 2582295-confirmation-cancel-links to hidden.

alexpott → changed the visibility of the branch 2582295-confirmation-cancel-links-11.x to active.

Hiding the irrelevant MRs and patches... someone needs to fix the 11.x MR as it has merge conflicts.

Rebased MRs.

smustgrave → changed the visibility of the branch 2582295-confirmation-cancel-links-10.2.x to hidden.

was going to post this issue for a weekly review but issue summary could use some work before reaching out to maintainers to take a look.

Fix the confirm URL in the node/translation delete confirm form.

Don't see anything in the MR that seems to just be targeting that form but more general Confirmation Form. S

User interface changes usually should contain before/after sceenshots if it's a UI change, probably will need a CR too.

Left some comments on the MR as well.

Somehow @smustgrave comments in the MR were lost. At least , I cannot see them. Tentatively setting back to NR

Reviewed merge request and updated issue summary.

I'm really concerned about false positives here. For example what happens if the base path is admin - the situation envisaged by #2417645: Change destination query string handling to break dependence on system path → where destinations can have or not have the base path is untenable. I think we need to complete the work on #2418219: Deprecate destination URLs that don't include the base path → which would end up having to fix this. Not sure what to do here.

We still don't have a subsystem maintainer review. I discussed with @catch and we agreed that this issue is really a duplicate of #2418219: Deprecate destination URLs that don't include the base path → and should be postponed on that issue. Until destination URLs are consistent, fixing this will be impossible.

for those using this solution with D10.1.8
you'll need to use this version:
https://git.drupalcode.org/project/drupal/-/commit/4b93d159a2e8b.diff

with that said, look at the duplicate issue #2418219 for a possible alternative.

lol, came full circle here,

Check this comment:

#2418219-25: Deprecate destination URLs that don't include the base path →

which describes patch #2 in 2418219

Looks like there's multiple use cases that need attention. What is above ^and also what is mentioned in
#2418219: Deprecate destination URLs that don't include the base path →

10.3 compatible