Hi fabienly,
Thanks for checking this out! Sorry it's not working out.
Here's what I do and the patch applies cleanly for me:
1) Create a new folder and git clone --branch 8.8.x https://git.drupalcode.org/project/drupal.git
2) Change directory to the root cd drupal
2) Add the patch to the root folder
3) Apply the patch git apply -v stark_help-2854576-40.patch
borisson_,
I'm certainly willing to defer on this, per your recommendation, I've added hidden to the patch.
Thank you
@borisson_,
Thanks for the clarification. Am I correct in understanding that in a simple change like this, any one of the tests would have been sufficient?
Hidden was not included in the patch as my intent was to continue to expose the Stark to /admin/appearance and allow it to be selected through the UI. With clearer help text, isn't it preferable to allow it to be quickly enabled for testing?
Reworded one last time.
Noticed a typo above and reworded to 'An intentionally plain theme for demonstrating and testing Drupal’s default HTML and CSS. Stark is not typically used as a base theme, instead learn how to build a custom theme in the <a href="https://www.drupal.org/docs/8/theming">Theming Guide</a>.'
vacho, you raise a very valid point that the theme should be displayed on /admin/appearance
How about if the description reads 'An intentionally plain theme for demonstrating and testing Drupal’s default HTML and CSS. Stark.x should not be used as a base theme, instead learn how to build a custom theme in the <a href="https://www.drupal.org/docs/8/theming">Theming Guide</a>.'?
Rerolled for 8.7.x-dev.
Drat; third time's a charm?
Oops. Patch fixed.
This patch exposes Stable and hides Stark from the /appearance page. It also changes the descriptions for both.
Morton, Thanks for your reply. Do you think we should at the same time also display Classy so uninformed folks don't mistakenly believe there is no longer a core basetheme?
NonProfit → created an issue. See original summary → .