Existing menu links show validation issues on migration (and ALL menu links pointing to node translations are invalid)

Open on Drupal.org →

Created on 28 April 2019, about 6 years ago

Updated 16 March 2023, about 2 years ago

Problem/Motivation

The d7_menu_links migration complains about failed path validation for many links.

The reason: it points to content entities that have not yet been migrated. Its migration dependencies are:

migration_dependencies:
  required:
    - d7_menu

While this guarantees the existence of the menu in which a migrated menu link lives, it does not guarantee that the location the menu link points to exists. This is the problem.

Proposed resolution

Add dependencies.
Add deriver, to allow migrating subsets of menu links (to be able to migrate only menu links targeting only content entities that have already been migrated).

Remaining tasks

Add tests for the deriver.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

TBD

🐛 Bug report

Status

Needs work

Version

10.1 ✨

Component

Last updated about 14 hours ago

Maintained by
🇺🇸United States @benjifisher
@heddn
🇺🇸United States @mikelutz
🇳🇿New Zealand @quietone

Created by

Live updates comments and jobs are added and updated live.

migrate-d7-d8

migrate-d7-d9

Needs subsystem maintainer review
It is used to alert the maintainer(s) of a particular core subsystem that an issue significantly impacts their subsystem, and their signoff is needed (see the governance policy draft for more information). Also, if you use this tag, make sure the issue component is set to the correct subsystem. If an issue significantly impacts more than one subsystem, use needs framework manager review instead.

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Incomplete comments

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment about 2 years ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Rerolling for 9.5.5. (#67 still applied fine to 9.5.2.)

🐛 Remove migration of shortcuts from menu_link migration Fixed conflicted with this in \Drupal\menu_link_content\Plugin\migrate\source\MenuLink. This patch already had the logic that that added in D7MenuLinkDeriverTrait::getBaseQuery().

(See #11.)
Status changed to Postponed 13 days ago7:43am 24 May 2025
Comment 13 days ago →
🇳🇿New Zealand quietone
The Migrate Drupal Module was approved for removal in 📌 [Policy] Migrate Drupal and Migrate Drupal UI after Drupal 7 EOL Fixed .

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project → and the Extensions approved for removal → policies.

The deprecation work is in 📌 [12.x] [Meta] Tasks to remove Migrate Drupal module Postponed and the removal work in 📌 [12.x] [Meta] Tasks to remove Migrate Drupal module Postponed .

Migrate Drupal will not be moved to a contributed project. It will be removed from core after the Drupal 12.x branch is open.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024