Dots in query parameter names converted to underscores

seems to have a test failure

Did not test or review.

Thanks to those who have worked on this. The test fail is in a test introduced in this MR and appears to be worth researching and fixing.

I updated to issue summary based on my review of this issue and the related symfony issue.

Given how fragile the reimplemention of parse_str could possibly be, what are the thoughts on introducing an additional dependency like league/uri-query-parser or league/uri-components to handle it?

Since they probably have more test coverages and well-tested.

We could also try using something along the lines of https://www.php.net/manual/en/function.parse-str.php#126789 as a base as well.

I agree with #75, but since Drupal already uses symfony/http-foundation, we could possibly use
\Symfony\Component\HttpFoundation\ Symfony\Component\HttpFoundation::parseQuery()?

I've tried HeaderUtils::parseQuery on the Australian Bureau of Meterology link http://www.bom.gov.au/cgi-bin/wrap_fwo.pl?IDN60140.html (which had two issues - the equals sign being added and the .html being changed to _html). It got through unmangled when extending the patch from #1464244 to replace parse_url in the line above.

Rather than stomping on the existing merge request, I'll attach my version as a patch in the first instance, and put it in the merge request if it gets favourable feedback.

Here's a small fix to the patch in 77.

And another tweak. Tests are coming.

So fixes should be into the MR. Not hiding the patches yet as not sure what needs to be folded in.

Also tagging for issue summary update as sections appear to be missing

Did not review.

I believe the patches were created to show what I said in #76 as a proof of concept. As long as there's no consensus on what to do between the suggestions of #75 and #76 I guess it makes sense not to clutter the MR with all the different ideas?

I'd be happy to submit it as "the" solution if that's what people want. Tests have been written; I could add them to the MR and credit my colleage, who wrote them.