- First commit to issue fork.
- Merge request !4909#2984272 Creating a fresh fork and apply fixes to query parms with dots and duplicate keys β (Open) created by NicholasS
- last update
8 months ago 30,143 pass, 9 fail - last update
8 months ago 30,160 pass, 9 fail - last update
8 months ago 30,352 pass, 1 fail - last update
8 months ago 30,352 pass, 1 fail - Status changed to Needs review
8 months ago 8:50pm 6 October 2023 - Status changed to Needs work
8 months ago 7:51pm 9 October 2023 - πΊπΈUnited States smustgrave
seems to have a test failure
Did not test or review.
- πΊπΈUnited States greggles Denver, Colorado, USA
Thanks to those who have worked on this. The test fail is in a test introduced in this MR and appears to be worth researching and fixing.
I updated to issue summary based on my review of this issue and the related symfony issue.
Given how fragile the reimplemention of
parse_str
could possibly be, what are the thoughts on introducing an additional dependency like league/uri-query-parser or league/uri-components to handle it?Since they probably have more test coverages and well-tested.
We could also try using something along the lines of https://www.php.net/manual/en/function.parse-str.php#126789 as a base as well.