During code quality scanning this line came into question:
core/lib/Drupal/Core/PathProcessor/PathProcessorFront.php Line 52
array_replace($parameters, $request->query->all());
if (!empty($components['query'])) {
parse_str($components['query'], $parameters);
array_replace($parameters, $request->query->all());
$request->query->replace($parameters);
}The entire line can be removed, or else $parameters can be assigned the return value of the call to array_replace. I believe that was the purpose, and would make sense to replace.
$parameters = array_replace($parameters, $request->query->all());
In developing a test for this, I found two additional issues introduced in #3000671: Frontpage with query parameter results in "Page not found" → :
When query parameters (GET vars) are present in Default front page URL, visiting / redirects the browser to the URL with the query removed.
For example (from the related issue):
Expected same behavior as when no query parameters present in Default front page: browser should load /admin/people?status=2 while remaining at /.
Needs work
9.5
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.
It is used to alert the maintainer(s) of a particular core subsystem that an issue significantly impacts their subsystem, and their signoff is needed (see the governance policy draft for more information). Also, if you use this tag, make sure the issue component is set to the correct subsystem. If an issue significantly impacts more than one subsystem, use needs framework manager review instead.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.
Not sure I can answer #13 so tagging for subsystem review
See this was also previously tagged for tests so that still needs to happen
Thanks!