- Issue created by @Hamid.ali
- Status changed to Needs review
about 1 year ago 1:14pm 15 June 2023 - last update
about 1 year ago Custom Commands Failed - Status changed to Needs work
about 1 year ago 2:05pm 15 June 2023 - 🇺🇸United States smustgrave
Will need screenshots for before/after
CC failure and depending on the fix a test case.
- 🇮🇳India lokeshsahu Delhi
On the #3 patch changes were made only on the CSS file and have no change on pcss file. I have created a patch to address the above issue including both files. I am attaching a screenshot showing the state before and after applying the patch.
- last update
about 1 year ago Custom Commands Failed - Status changed to Needs review
about 1 year ago 9:20am 16 June 2023 - Issue was unassigned.
- Status changed to RTBC
about 1 year ago 10:01am 16 June 2023 Verified and tested the #6 patch on 10.1.x, the position of the hamburger menu is fixed. Added screenshots for reference, RTBC++.
- Status changed to Needs work
about 1 year ago 11:08am 16 June 2023 - 🇫🇮Finland lauriii Finland
It looks like CI is failing for the patch: https://www.drupal.org/pift-ci-job/2693856 →
- First commit to issue fork.
- last update
about 1 year ago 29,430 pass - @rpayanm opened merge request.
- Status changed to Needs review
about 1 year ago 3:46pm 16 June 2023 - 🇺🇸United States smustgrave
Tagging for submaintainer to confirm if this is actually a bug.
- 🇮🇪Ireland markconroy
I don't think this is a bug, I think this is the actual design. If you look at it (and use a screen ruler) you can see that the "Menu" text aligns with the bottom of the "Site name" text.
That said, I do prefer the look of the menu position when the patches in this issue are applied, with the menu icon/text centered vertically.
Looking forward to Mike Herchel's 2c.
- Status changed to Postponed: needs info
about 1 year ago 1:03pm 20 June 2023 - 🇺🇸United States mherchel Gainesville, FL, US
Yeah, I don't see what the issue is. Is it the vertical alignment? If so, this is per design. If it's something else, please detail and provide some annotated screenshots.
Thanks