- 🇳🇿New Zealand quietone New Zealand
Both theme_links and theme_item_list have been removed from core. Instead twig templates, links.html.twig and item_list.html.twig, are used. Therefore, I am closing this as outdated.
We have two very similar functions in Durpal theme_links and theme_item_list. Both of these functions loop through a set of items, and create a HTML list. This creates twice as much code to maintain, and two separate, nearly identical, things to keep up to date.
The plan is to use theme_links() when a title and/or wrapper div is necessary, and theme_links() will call theme('item_list') to generate the list of items within. In turn, theme_item_list() will not contain a wrapper div or title anymore.
This means we will need to update core to use theme_links()) any time a title or wrapper div is necessary, and may need to
'title' => NULL, to theme_item_list() that will no longer accept a titleThere are eighty-three (83) instances of 'item_list' in core. Below is a list of *only* the ones that will need to be updated (since they require either a title or a surrounding div tag)
List of all instances of calls to theme('item_list') or render arrays with '#theme' => 'item_list' where a title or wrapper div is warranted
None.
None.
📌
Replace links.html.twig with item-list--links.html.twig
Needs work
📌
Remove title and wrapper div from item-list.html.twig
Needs work
Closed: outdated
11.0 🔥
Last updated
It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.
Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.
It is used to alert the maintainer(s) of a particular core subsystem that an issue significantly impacts their subsystem, and their signoff is needed (see the governance policy draft for more information). Also, if you use this tag, make sure the issue component is set to the correct subsystem. If an issue significantly impacts more than one subsystem, use needs framework manager review instead.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Both theme_links and theme_item_list have been removed from core. Instead twig templates, links.html.twig and item_list.html.twig, are used. Therefore, I am closing this as outdated.