Remove $authorized param to UpdateMailTest::testUpdateEmail()

This is going to conflict with 🐛 Correct & improve update status email subject Postponed , let's land that, first.

Per Slack with @xjm, expanding scope here to actually fix UpdateMailTest on its own, before trying to add more coverage to it at 🐛 Correct & improve update status email subject Postponed .

I believe this is ready. The test is passing locally, so if the pipeline isn't green, it's due to a random fail. 😅

For this one I actually did the side-by-side review as it was easier then inline.

The matrix of core and contrib hitting every combo of current, not current, not secure, secure appear to be hit.

Question do we need coverage for REVOKED and NOT_SUPPORTED?

Thanks for the review!

Good question about the other statuses. "need" is a strong word. 😂 I'm slightly worried that every possible combination of all possible status values for core vs. contrib will explode the size of this data provider. It's not like the logic in _update_message_text() is all that complicated. Seems plausible that we don't need to test every possible code path in there. This MR is already larger than the "combined" MR that prompted splitting this off to a separate issue. 😅 I don't want to explode the scope here more than I already have.

I vote we get this in ASAP as a significant improvement to what we have now (and to unblock the bugfix that prompted this). If we decide we need more cases later, we can always add them easily enough.

Thanks,
-Derek

Works for me, thanks for the quick reply!

@dww, thanks for fixing my mistakes and improving this test.

I reviewed this for my own benefit and did not find any problems.

You’re welcome and thanks for the review. Since this task is blocking a bug fix, tagging.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Rebase with a simple conflict in UpdateMailTest due to the change to using an attribute for @group. Therefor, restoring RTBC

I made a mistake in the rebase and didn't properly remove an argument from the method testUpdateEmail, which the tests found. I have corrected that and tests are passing. I think it is minor, to I am leaving this at RTBC.