If a module is Not Supported, Drupal's warning links to available updates page, which says everything is OK

Open on Drupal.org →

Created on 3 November 2010, about 14 years ago

Updated 15 April 2024, 7 months ago

Problem/Motivation

Say you're on the modules page and update manager tells you this:

The installed version of at least one of your modules or themes is no longer supported. Upgrading or disabling is strongly recommended. See the project homepage for more details. See the available updates page for more information and to install your missing updates.

The text "available updates" is then linked to admin/reports/updates/update which says:

All of your projects are up to date.

It's necessary to go to admin/reports/updates to see what module and what the issue is:

Project not supported: This project is no longer supported, and is no longer available for download. Disabling everything included by this project is strongly recommended!

Proposed resolution

Include information about unsupported projects on the 'Update' form at /admin/reports/updates/update

Include them in the 'Manual updates required' table - YES

See #25

Also as part of this issue, make the following changes to this table:

Change the heading of that table to something more generic, perhaps "Recommended action".
Change the existing entry in that column (in the row for Drupal core) to a full sentence: something like "Upgrade to 8.8.x ...".
Rewrite the second sentence in the new row to avoid the passive voice.

- No

Along the lines of what we did at #3113992: The 'Update' page has no idea that some updates are incompatible → . A separate table might be easier to deal with, we can optimize the column headers to make sense for unsupported projects, etc.

Downside: Adds Yet More Tables(tm) to this page. In a really wonky example, a site might have 5 tables on this page:

Normal available updates with checkboxes to update them (the functional part of this UI)
Manual updates (core)
Unsupported projects (this issue)
Incompatible updates #3113992: The 'Update' page has no idea that some updates are incompatible →
Uninstalled/disabled projects 🐛 Change UI for /admin/reports/updates/update to not mention "Enabled/Disabled" modules and themes Fixed

Something like:

Unsupported projects

(more or less).

Remaining tasks

Implement it. #38
Update/add test coverage.
Reviews/refinements.
RTBC.
Commit.

User interface changes

Changes to the "Manual updates required" table on the update your site form at /admin/reports/updates/update:

Include rows for projects that are now marked unsupported.
Change the heading of that table to something more generic, perhaps "Recommended action".
Change the existing entry in that column (in the row for Drupal core) to a full sentence: something like "Upgrade to 9.1.2 ...".
Rewrite the second sentence in the new row to avoid the passive voice.

Before

After

API changes

Probably nothing public.

Data model changes

Nope.

Release notes snippet

TBD.

🐛 Bug report

Status

Needs work

Version

11.0 🔥

Component

Last updated about 4 hours ago

Maintained by
🇺🇸United States @tedbow
🇺🇸United States @dww

Created by

🇺🇸United States mlncn Minneapolis, MN, USA

Live updates comments and jobs are added and updated live.

String freeze
It affects the translatable strings and it should be committed before the string freeze milestone of the release cycle.

Update manager

Needs backport to D7
After being applied to the 8.x branch, it should be considered for backport to the 7.x branch. Note: This tag should generally remain even after the backport has been written, approved, and committed.

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Incomplete comments

Sign in to follow issues

Merge Requests

!7490If a module is Not Supported, Drupal's warning links to available updates page, which says everything is OK
Open
🇳🇿New Zealand quietone
updated 7 months ago

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
157 pass, 2 fail
Comment over 1 year ago →
🇳🇿New Zealand quietone
I rerolled and then updated the patch according to #38. I started from the patch in #25 because of the comments about brackets in #33 and #34, and there was no diff.

I've added some if statements to get around a possible undefined variable. It is a bit messy but instead of focusing on that I want to see what tests fail. Also, I am getting PHPStan errors locally on a line not changed by this patch so want to see what testbot does.
Comment over 1 year ago →
System Message
The last submitted patch, 48: 961060-48.patch, failed testing. View results →
Status changed to Needs work over 1 year ago9:45am 1 August 2023
Comment over 1 year ago →
🇩🇰Denmark ressa Copenhagen
Thanks, just updating the title, which lost "upal's" :)
Comment 7 months ago →
🇳🇿New Zealand quietone
Just converted to an MR and hid patched, nothing else.
Merge request !7490If a module is Not Supported → (Open) created by quietone

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024