- Merge request !1689Issue #1503146: drupal_is_front_page() does not detect Front Page in some cases → (Open) created by DieterHolvoet
- last update
about 1 year ago 29,381 pass, 4 fail - 🇺🇸United States DamienMcKenna NH, USA
The merge request rerolled as SiteInformationForm.php had a conflict.
- Assigned to DamienMcKenna
- Status changed to Needs work
about 1 year ago 10:40am 23 May 2023 - 🇺🇸United States DamienMcKenna NH, USA
Looking at the test failures, it seems like the failures in both TaxonomyDefaultArgumentTest and DisplayPageTest could be fixed by adding path_alias to the test's modules list. I'll test this locally first.
- Status changed to Needs review
about 1 year ago 11:22am 23 May 2023 - last update
about 1 year ago 29,389 pass, 2 fail - 🇺🇸United States DamienMcKenna NH, USA
I made a few additional changes and was able to get the tests to pass locally. Whether we want to make these changes to the tests is another question.
- Issue was unassigned.
The last submitted patch, 69: drupal-n1503146-69.patch, failed testing. View results →
The last submitted patch, 72: drupal-n1503146-72.patch, failed testing. View results →
- Status changed to Needs work
about 1 year ago 12:31pm 23 May 2023 - 🇺🇸United States DamienMcKenna NH, USA
That's weird - InstallerExistingConfigSyncDirectoryMultilingualTest passes locally, and didn't fail on previous test runs, e.g. https://www.drupal.org/pift-ci-job/2673595 → from #69.
Anyways, next off we need test coverage.
- Open on Drupal.org →Environment: PHP 8.2 & MySQL 8last update
11 months ago Not currently mergeable. - last update
11 months ago 29,869 pass, 4 fail - last update
8 months ago Patch Failed to Apply - First commit to issue fork.
- 🇺🇸United States neclimdul Houston, TX
neclimdul → changed the visibility of the branch 11.x to hidden.
- 🇺🇸United States neclimdul Houston, TX
neclimdul → changed the visibility of the branch 11.x to hidden.
- 🇺🇸United States neclimdul Houston, TX
neclimdul → changed the visibility of the branch 11.x to hidden.
- 🇺🇸United States neclimdul Houston, TX
sorry for the noise. Forcing a 11.x branch to the issue fork to work around a bug in the core gitlab config.
The patch seems to be working great. Note about how we can make it better in the review.